Skip to content

Add dropdown arrows to sections#639

Merged
AaronCrawfis merged 2 commits into
v0.22from
aacrawfi/section-arrows
Jul 6, 2023
Merged

Add dropdown arrows to sections#639
AaronCrawfis merged 2 commits into
v0.22from
aacrawfi/section-arrows

Conversation

@AaronCrawfis
Copy link
Copy Markdown

Adds a dropdown arrow to sections

Also updates the CSS to make pages and sections look the same

@AaronCrawfis AaronCrawfis requested a review from a team as a code owner July 5, 2023 20:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-639.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-639.westus2.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis merged commit 2027603 into v0.22 Jul 6, 2023
@AaronCrawfis AaronCrawfis deleted the aacrawfi/section-arrows branch July 6, 2023 22:24
willtsai added a commit that referenced this pull request Jul 7, 2023
* Create .gitattributes

* Add dropdown arrows to sections (#639)

* Add output for failed spellcheck runs (#641)

* Add output steps

* Add misspelled word

* Switch comment provider

* Clear comment on success

* Rename job

* Add concurrency control

* Fix spelling issue

* Disable section pages (#644)

* Disable section page nav

* Update section pages

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Remove _ for leaf pages

---------

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Update sidebar GitHub links and taxonomies (#638)

* Update GitHub issues links

* Only show tags/categories on home page

* v0.22 to edge upmerge

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* v0.22 to edge upmerge

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
@Reshrahim
Copy link
Copy Markdown
Contributor

@AaronCrawfis - This is great! When navigating I noticed that the page that has a dropdown doesn't get rendered in the right pane. On click, only the dropdown list in the left pane expands. Bird's eye view of the section is lost

@AaronCrawfis
Copy link
Copy Markdown
Author

AaronCrawfis commented Jul 10, 2023

@AaronCrawfis - This is great! When navigating I noticed that the page that has a dropdown doesn't get rendered in the right pane. On click, only the dropdown list in the left pane expands. Bird's eye view of the section is lost

@Reshrahim Could you paste a screenshot and steps to recreate? Can get that fixed today. Thanks!

Edit (I just re-read, we intended to get rid of the overview page)

@Reshrahim
Copy link
Copy Markdown
Contributor

ooh so this view is intentionally not available anymore on clicking Quickstarts?

image

@AaronCrawfis
Copy link
Copy Markdown
Author

ooh so this view is intentionally not available anymore on clicking Quickstarts?

For now, correct. Let's discuss later today on some ideas on how to bring a version of this page back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants