Disable section pages#644
Merged
Merged
Conversation
added 2 commits
July 6, 2023 17:04
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-644.westus2.azurestaticapps.net |
willtsai
requested changes
Jul 7, 2023
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-644.westus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-644.westus2.azurestaticapps.net |
willtsai
approved these changes
Jul 7, 2023
willtsai
added a commit
that referenced
this pull request
Jul 7, 2023
* Create .gitattributes * Add dropdown arrows to sections (#639) * Add output for failed spellcheck runs (#641) * Add output steps * Add misspelled word * Switch comment provider * Clear comment on success * Rename job * Add concurrency control * Fix spelling issue * Disable section pages (#644) * Disable section page nav * Update section pages * Apply suggestions from code review Co-authored-by: Will <28876888+willtsai@users.noreply.github.com> * Remove _ for leaf pages --------- Co-authored-by: Will <28876888+willtsai@users.noreply.github.com> * Update sidebar GitHub links and taxonomies (#638) * Update GitHub issues links * Only show tags/categories on home page * v0.22 to edge upmerge Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * v0.22 to edge upmerge Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> --------- Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables section pages.
But wait, why would we do that!?!?
Well, for one the section pages don't offer a ton of value. They have an auto-generated summary of the child pages, but they don't have much content themselves. This causes people to land on one and wonder "ok now what, which link do I choose?"
In this new format, users can click on sections and they will expand to show what's in the section. Then they can choose to look at an overview page detailing the resource, or they can choose one of the sub-pages.