Skip to content

Generate openmp metadata#151071

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ZuseZ4:gen-openmp-metadata
Jan 19, 2026
Merged

Generate openmp metadata#151071
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ZuseZ4:gen-openmp-metadata

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Jan 13, 2026

LLVM has an openmp-opt pass, which is part of the default O3 pipeline.
The pass bails if we don't have a global called openmp, so let's generate it if people enable our experimental offload feature. openmp is a superset of the offload feature, so they share optimizations.
In follow-up PRs I'll start verifying that LLVM optimizes Rust the way we want it.

r? compiler

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2026
@ZuseZ4 ZuseZ4 mentioned this pull request Jan 13, 2026
5 tasks
@ZuseZ4 ZuseZ4 added the F-gpu_offload `#![feature(gpu_offload)]` label Jan 13, 2026
@nnethercote
Copy link
Contributor

  • Can you squash the commits? I assume the test will fail if only the first commit is applied.
  • There's a type fro in one of the commit messages.
  • Please write a short PR description.

@ZuseZ4 ZuseZ4 force-pushed the gen-openmp-metadata branch from 2134553 to 5c85d52 Compare January 16, 2026 19:57
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Jan 16, 2026

@rustbot review

@nnethercote
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 5c85d52 has been approved by nnethercote

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151071 (Generate openmp metadata)
 - #151302 (add lint test)
 - #151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - #151354 (ci: Move lockfile updates to a script)

r? @ghost
@rust-bors rust-bors bot merged commit a56e2d3 into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
Rollup merge of #151071 - gen-openmp-metadata, r=nnethercote

Generate openmp metadata

LLVM has an openmp-opt pass, which is part of the default O3 pipeline.
The pass bails if we don't have a global called openmp, so let's generate it if people enable our experimental offload feature. openmp is a superset of the offload feature, so they share optimizations.
In follow-up PRs I'll start verifying that LLVM optimizes Rust the way we want it.

r? compiler
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151071 (Generate openmp metadata)
 - rust-lang/rust#151302 (add lint test)
 - rust-lang/rust#151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - rust-lang/rust#151354 (ci: Move lockfile updates to a script)

r? @ghost
@ZuseZ4 ZuseZ4 deleted the gen-openmp-metadata branch January 31, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-gpu_offload `#![feature(gpu_offload)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants