Skip to content

add lint test#151302

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
KaiTomotake:add-lint-test
Jan 19, 2026
Merged

add lint test#151302
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
KaiTomotake:add-lint-test

Conversation

@KaiTomotake
Copy link
Contributor

@KaiTomotake KaiTomotake commented Jan 18, 2026 •
edited by rustbot
Loading

closes #138069, which was already fixed.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@KaiTomotake
Copy link
Contributor Author

KaiTomotake commented Jan 18, 2026 •
edited
Loading

I added a test for the unused_assignments false positive issue..
The test has been added under tests/lint/unused.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
reddevilmidzy
reddevilmidzy reviewed Jan 18, 2026
View reviewed changes
lqd
lqd reviewed Jan 18, 2026
View reviewed changes
@rustbot rustbot assigned lqd and unassigned BoxyUwU Jan 18, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@KaiTomotake @reddevilmidzy
add lint test
3a8b577 
Co-authored-by: Redddy <midzy0228@gmail.com>
@KaiTomotake KaiTomotake requested a review from lqd January 19, 2026 01:52
@KaiTomotake
Copy link
Contributor Author

KaiTomotake commented Jan 19, 2026

If this PR gets merged, I would appreciate it if #146447 could also be closed at the same time.
This issue was previously assigned to me, and the corresponding PR has already been merged.

@lqd
Copy link
Member

lqd commented Jan 19, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 3a8b577 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 19, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
@bors
Auto merge of #151360 - JonathanBrouwer:rollup-UpAM1gc, r=JonathanBro…
158ae9e 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151071 (Generate openmp metadata)
 - #151302 (add lint test)
 - #151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - #151354 (ci: Move lockfile updates to a script)

r? @ghost
@rust-bors rust-bors bot merged commit 3f01ca0 into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
@rust-timer
Unrolled build for #151302
dc6e6fe 
Rollup merge of #151302 - add-lint-test, r=lqd

add lint test

closes #138069, which was already fixed.
@KaiTomotake KaiTomotake deleted the add-lint-test branch January 19, 2026 13:26
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151360 - JonathanBrouwer:rollup-UpAM1gc, r=JonathanBro…
6793500 
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151071 (Generate openmp metadata)
 - rust-lang/rust#151302 (add lint test)
 - rust-lang/rust#151338 (Factor out diagnostic slug checking from `DiagnosticDerive` )
 - rust-lang/rust#151354 (ci: Move lockfile updates to a script)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddevilmidzy reddevilmidzy Awaiting requested review from reddevilmidzy

@lqd lqd Awaiting requested review from lqd

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

unused_assignments lint has trouble tracking that one match guard observes assignment from another match guard.

6 participants

@KaiTomotake @rustbot @rust-log-analyzer @lqd @reddevilmidzy @BoxyUwU