Factor out diagnostic slug checking from DiagnosticDerive #151338
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Jan 19, 2026
Merged
Factor out diagnostic slug checking from DiagnosticDerive #151338rust-bors[bot] merged 2 commits intorust-lang:mainfrom
DiagnosticDerive #151338rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
cc @davidtwco, @TaKO8Ki |
rustbot
added
A-translation
Member
|
so basically this removes some checks for ftl files? |
Contributor
Author
|
This PR should not change observable behaviour. |
Member
|
ah, yeah i see it was duplicated, so now it's just a single method in |
Kivooeo
approved these changes
Jan 18, 2026
…DiagnosticDerive`
JonathanBrouwer
force-pushed
the
factor_slug
branch
from
4c96713 to
7216b03
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r=Kivooeo rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Jan 19, 2026
Rollup merge of #151338 - factor_slug, r=Kivooeo Factor out diagnostic slug checking from `DiagnosticDerive` Doing some cleanup work in preparation for rust-lang/compiler-team#959 r? @Kivooeo
8 tasks
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 20, 2026
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#151071 (Generate openmp metadata) - rust-lang/rust#151302 (add lint test) - rust-lang/rust#151338 (Factor out diagnostic slug checking from `DiagnosticDerive` ) - rust-lang/rust#151354 (ci: Move lockfile updates to a script) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some cleanup work in preparation for rust-lang/compiler-team#959
r? @Kivooeo