Skip to content

rustc_public: add vtable_entries() to TraitRef#152669

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
makai410:rpub-vtable
Mar 20, 2026
Merged

rustc_public: add vtable_entries() to TraitRef#152669
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
makai410:rpub-vtable

Conversation

@makai410
Copy link
Member

@makai410 makai410 commented Feb 15, 2026

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: project-stable-mir
  • project-stable-mir expanded to celinval, makai410, oli-obk, scottmcm
  • Random selection from celinval, scottmcm

celinval
celinval reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! To close the issue, we still need to add an API that takes the index and return the respective definition. Do you mind adding it to this CR? Thanks!

View changes since this review

@makai410
Copy link
Member Author

makai410 commented Mar 10, 2026

Awesome! To close the issue, we still need to add an API that takes the index and return the respective definition. Do you mind adding it to this CR? Thanks!

View changes since this review

We could use vtable_entries().get(idx), right?

@celinval
Copy link
Contributor

celinval commented Mar 13, 2026

Sure... Just more ergonomic and we could avoid translating all definitions when only one is needed. Since it's a common occurrence when translating a virtual function call.

@rustbot

This comment has been minimized.

Sign in to view
@makai410
Copy link
Member Author

makai410 commented Mar 16, 2026

Ah good point, I didn’t think of that.

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

celinval
celinval approved these changes Mar 20, 2026
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

Unknown command "e+". Run @bors help to see available commands.

@celinval
Copy link
Contributor

celinval commented Mar 20, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

📌 Commit 96893dc has been approved by celinval

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152669 - makai410:rpub-vtable, r=celinval
103d060 
rustc_public: add `vtable_entries()` to `TraitRef`

Resolves: rust-lang/project-stable-mir#103
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 20, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152669 - makai410:rpub-vtable, r=celinval
54c9e4d 
rustc_public: add `vtable_entries()` to `TraitRef`

Resolves: rust-lang/project-stable-mir#103
This was referenced Mar 20, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 20, 2026
@bors
Auto merge of #154137 - JonathanBrouwer:rollup-hTMxxjl, r=JonathanBro…
bfc05d6 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #154103 (coretests: Expand ieee754 parsing and printing tests to f16)
 - #152669 (rustc_public: add `vtable_entries()` to `TraitRef`)
 - #153776 (Remove redundant `is_dyn_thread_safe` checks)
 - #154121 (Fix typos and markdown errors)
 - #154126 (refactor(attribute parser): move check_custom_mir to attribute parser)
@rust-bors rust-bors bot merged commit 65f1783 into rust-lang:main Mar 20, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celinval celinval celinval approved these changes

Assignees

@celinval celinval

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Add vtable info

3 participants

@makai410 @rustbot @celinval