Rollup of 5 pull requests#154136
Closed
JonathanBrouwer wants to merge 16 commits intorust-lang:mainfrom
Closed
Conversation
This is just a single file, so move it under `num` which already has some float-related tests. This also closer mirrors source in `core`.
Use `float_test!` to cover all types, with a note about f128 missing the traits.
coretests: Expand ieee754 parsing and printing tests to f16 Use `float_test!` to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.
rustc_public: add `vtable_entries()` to `TraitRef` Resolves: rust-lang/project-stable-mir#103
…d-safe, r=JonathanBrouwer Remove redundant `is_dyn_thread_safe` checks Refactor uses of `FromDyn` to reduce number of redundant `is_dyn_thread_safe` checks by replacing `FromDyn::from` with `check_dyn_thread_safe` in tandem with existing `FromDyn::derive` so that the users would avoid redundancy in the future. PR is split up into multiple commits for an easier review.
…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.
…er, r=JonathanBrouwer refactor(attribute parser): move check_custom_mir to attribute parser Part of rust-lang#153101 r? @JonathanBrouwer
rustbot
added
A-attributes
Member
|
Sorry if i'm misunderstanding rollups but is this a (older) duplicate of #154137? |
Contributor
Author
|
Huh interesting, I got weird errors (errorcode 500 from github) when making the rollup so I pressed the "Create rollup" button again, but I guess the first click did actually make this PR |
rustbot
removed
the
S-waiting-on-review
Member
|
It is interesting that this didn't get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
vtable_entries()toTraitRef#152669 (rustc_public: addvtable_entries()toTraitRef)is_dyn_thread_safechecks #153776 (Remove redundantis_dyn_thread_safechecks)r? @ghost
Create a similar rollup