coretests: Expand ieee754 parsing and printing tests to f16#154103
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Mar 20, 2026
Merged
coretests: Expand ieee754 parsing and printing tests to f16#154103rust-bors[bot] merged 3 commits intorust-lang:mainfrom
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
This is just a single file, so move it under `num` which already has some float-related tests. This also closer mirrors source in `core`.
rustbot
added
S-waiting-on-review
tgross35
force-pushed
the
float-test-mod
branch
from
d9417d6 to
07a89fe
Compare
This comment has been minimized.
This comment has been minimized.
Use `float_test!` to cover all types, with a note about f128 missing the traits.
tgross35
force-pushed
the
float-test-mod
branch
from
07a89fe to
16f8985
Compare
Collaborator
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
Contributor
Author
|
Note that the individual commits should be reviewed here; git does track the moved file but GH's overall diff shows it as a delete + re-add |
folkertdev
reviewed
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Some nice code quality improvements along with the additional test coverage.
@bors r+
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 20, 2026
coretests: Expand ieee754 parsing and printing tests to f16 Use `float_test!` to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 20, 2026
coretests: Expand ieee754 parsing and printing tests to f16 Use `float_test!` to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.
This was referenced Mar 20, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2026
…uwer Rollup of 5 pull requests Successful merges: - #154103 (coretests: Expand ieee754 parsing and printing tests to f16) - #152669 (rustc_public: add `vtable_entries()` to `TraitRef`) - #153776 (Remove redundant `is_dyn_thread_safe` checks) - #154121 (Fix typos and markdown errors) - #154126 (refactor(attribute parser): move check_custom_mir to attribute parser)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
float_test!to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.r? @folkertdev