Conversation
Contributor
turso
commented
Oct 21, 2020
turso
commented
Renaming is part of commits making the dockerized services run as a non-root user.
New nginx.conf contains configurations for the server instance. This commit is a part of series of commits to make the dockerized services run as a non-root.
This commit is a part of series of commits to make the dockerized services run as a non-root user.
This commit is a part of series of commits to make the dockerized services run as a non-root user.
…ver url Nginx port and backend server url can be overridden whit build args when building the Docker image. Arguments are nginx_port (default value 8080) and backend_url (default http://backend-server:5000).
When running command 'docker-compose up' frontend fails with status code 0. This will fix that bug. This is known issue https://dev.to/igmrrf/docker-react-exited-with-code-0-398n
For some reason container failed to start in OpenShift when log directory was under /tmp due permission reasons so this moves them back to the orginal directory.
Adding URL support for checkboxes and Testing
…file Adds new section about the configurable Docker build arguments inside the Dockerfile-prod.
Fixes issue with react and docker-compose up
Feature/ui fix list
Backend server's docker file was configured to expose always the port 5000, which might not match with the $PORT argument given to server.
Feature/docker services run nonroot
vade5g
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.