Conversation
This geocodes locations in meetups.yml using the geocoder gem.
Rakefile
Outdated
There was a problem hiding this comment.
Is there a better approach than this? Perhaps a group API?
There was a problem hiding this comment.
Probably a good idea, and I guess it could also provide a place in the code for data preparation using the meetups.com API that has been discussed for the future. I will attempt a refactoring later - hopefully this evening
|
Adding explicit reference: emberjs#1904. It feels silly that this is needed... but it's useful to be able to see the status on the main PR page 😛 |
|
@solsberg This is good stuff! I added a bunch of comments, but overall this looks sound. |
|
Merged. Thanks, @solsberg! |
|
I just noticed that the map markers don't show up and the location links don't work when location detection is off in the browser. Is this related to solsberg@6626de2? |
|
My PR(#9) will fix this. Just working on getting the Retina images in now - On Tue, Jan 13, 2015 at 10:18 PM, Sandra notifications@github.com wrote:
|
5 participants
This is a new pull request to replace my previous one
The geocode rake task will now simply calculate lng/lat fields for the group records in meetups.yml where no such values already exist. It will use an 'address' field if it find one (this allows specifying a more accurate street address to geocode), otherwise it will use the location field to geocode to a general coordinate in the city.
I have also included a commit which allows the map to go ahead and draw even in the case when the user does not permit the geolocation API to lookup the current location. In this case the map is displayed to the extent of all the markers. Previously in this case the map would display without any of the markers.