Seperate drawMap from zoomToPosition and add configuration for clusters#9
Conversation
alexclarkofficial
changed the title
|
Do we have the PNG's we would like to use for the clusters? This is the most basic implementation, but I'd be happy to do the CSS to make it look right. |
|
Oh, also I just figured out how to set the break points for cluster size. If we'd like to change cluster images at different sizes let me know (I think it's currently set to 2 and 10). |
|
RE: image for clusters: best answered by @sandraor |
|
Thanks, @alexclarkofficial! Here are the two cluster images. The first one is designed for 1 digit, the second one for 2 digits, both with white text. The smallest breakpoint (2) seems too aggressive, so can we try it at 4?
|
|
Thanks @sandraor! I went with the smaller image for each cluster size that you provided. I tried smallest breakpoints of both 3 and 4. You can check out the results below. Let me know what you think and any other remarks about styling and I'll make the commit. Globe with smallest breakpoint of 3: Globe with smallest breakpoint of 4: Europe with smallest breakpoint of 3: Europe with smallest breakpoint of 4: |
|
I'm way too excited to get this merged in 😀 |
source/javascripts/meetups.js
Outdated
There was a problem hiding this comment.
Something seems weird about the indentation style here.
There was a problem hiding this comment.
That is weird - it will be fixed in my next commit.
|
Making sure we're all on the same page here: @alexclarkofficial is fixing a couple indentation changes, and then this is good to be merged. He'll comment here (and/or here too: emberjs#1904) to let @sandraor know when #9 is ready to be merged in. |
|
Thanks @wifelette! I was hoping to get @sandraor's design approval and final comment on the smallest breakpoint for clusters - but other than that I can make the commit anytime. |
|
I think the breakpoint at 4 looks best. Thanks for testing them out! Also, I just noticed that github didn't keep or display the names of the cluster images I uploaded, so I'm sorry, what I said about them didn't make much sense! :( I think only the larger image needs to be changed: This is for the small breakpoint (map-cluster-1.png): https://cloud.githubusercontent.com/assets/2864198/5715531/599d9ba8-9aa8-11e4-9537-45c10012ac8c.png This is for the large breakpoint (map-cluster-2.png): https://cloud.githubusercontent.com/assets/2864198/5715533/59a443c2-9aa8-11e4-92fc-edd75c434146.png Then I think it's ready to go! :D |
|
Changes have been made, but unfortunately I couldn't figure out how to include the URLs for the retina images. The doc's showed a boolean for enabling retina images, but no details on how to include them. |
Seperate drawMap from zoomToPosition and add configuration for clusters
|
No worries — I just included them in case they were needed. This looks great! Thank you! :) |
4 participants
In reference to: emberjs#1904