Fix checking if navigator.geolocation is available and how buildMap is called#8
Closed
alexclarkofficial wants to merge 23 commits intosandraor:masterfrom
alexclarkofficial:master
Closed
Fix checking if navigator.geolocation is available and how buildMap is called#8alexclarkofficial wants to merge 23 commits intosandraor:masterfrom alexclarkofficial:master
navigator.geolocation is available and how buildMap is called#8alexclarkofficial wants to merge 23 commits intosandraor:masterfrom
alexclarkofficial:master
Conversation
[Ember Users] adding Netural to the list of Ember users
…a.14.1 Ember Data v1.0.0-beta.14.1 blogpost and api docs
See github.com/emberjs/ember.js/issues/2242 and github.com/emberjs/ember.js/pull/3017
Leading underscore no longer a requirement
Adds Ticketfly as user
fixes ticketfly image
Add Duda as an ember-user
Ember Data's build tools were refactored recently and `npm run dist` no longer works. This pr updates the generate_ember_data_docs script to call `npm run build:production`
Fix Ember Data API docs build script
Add BookingSync as user
Using `{{outlet modal}}` produces warning:
~~~~
DEPRECATION: Using {{outlet}} with an unquoted name is not supported. Please update to quoted usage '{{outlet "modal"}}'.
at outletHelper (http://localhost:4200/assets/vendor.js:34983:13)
at Object.__exports__.default.Ember.Handlebars.template.main (grruca/templates/application.js:10:105)
at ret (http://localhost:4200/assets/vendor.js:11023:32)
at CoreView.extend.render (http://localhost:4200/assets/vendor.js:56437:20)
at EmberRenderer_createElement [as createElement] (http://localhost:4200/assets/vendor.js:53540:16)
at EmberRenderer.Renderer_renderTree [as renderTree] (http://localhost:4200/assets/vendor.js:23631:24)
at EmberRenderer.scheduledRenderTree (http://localhost:4200/assets/vendor.js:23708:16)
at Queue.invoke (http://localhost:4200/assets/vendor.js:14393:18)
at Object.Queue.flush (http://localhost:4200/assets/vendor.js:14458:13)
~~~~
Remove deprecated code example from Cookbook
|
Heya— There are a bunch of older additional commits packaged up here, unsure why. Do you need to rebase, perhaps? Let's definitely get it sorted before we merge this in. Also, adding the reference link: emberjs#1904 |
Author
|
Hey, Yeah, I probably need to rebase. Sorry, I'm really new to open source. Also, I got a bit ahead of myself and the code doesn't do quite what I thought it did. I'll get this cleaned up and send it back over. Thanks for your patience! |
|
S'all good—most of the people working on this PR are super new, so we're all making lots of newbie mistakes :p We'll get it done though! We'll keep an eye out for your updates. |
Fix check if `navigator.geolocation` is supported and allowed
Author
|
Got in over my head with this one. Ended up redoing the PR at #9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a more robust check to see if the browser has
navigator.geolocationand that the user allows itWrapped the call to
buildMapin a function that passes position