V.1.22.0 update #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* - Removed maintaining own cache of transactions, it is better to use SKPaymentQueue.transactions where needed - Removed unnecessary and broken payment validation from addPayment - Refactored finishTransaction for finishing transactions properly - Fixed: restoreTransactions did not call result(nil) causing the call never complete * - Updated changelog * - Fixed call to finishTransaction: parameter must be transactionIdentifier, not productIdentifier * - review fixes: verify in addPayment there are no pending transactions for the same product * - reverted accidental change * - fixed formatting issues * - fixed formatting issues * - fixed test (removed obsolete references to old transactions cache) * - removed obsolete test testAddPaymentWithSameProductIDWillFail - fixed sk_methodchannel_apis_test * - removed testDuplicateTransactionsWillTriggerAnError Co-authored-by: LHLL <yijiexu@google.com>
…example (#2986) * [integration_test] Recommend tests to be in `integration_test/`, fix example In this way, there is a clear distinction between integration tests that run on a device (in `integration_test/`, and widget tests that run with the flutter tester in `test/`. Fix flutter/flutter#64690
A new version of the formatter or something might have rolled in, causing CI to break
Adds a federated Windows implementation of url_launcher (not yet endorsed). Since this is the first C++ plugin, this also adds a .clang-format file to the repo root for formatting C++ plugins. Part of flutter/flutter#41721 (will need follow-up to endorse it in url_launcher)
-Werror and code cleanup for Java code.
Instead of throwing JS objects, or attempting to access undefined properties. This change also migrates tests to the `integration_test` package.
Endorses url_launcher_windows so that Windows is supported automatically.
…t working on Android (#3037)
Implements path_provider for Windows, adding path_provider_windows and endorsing it in path_provider.
- Adds missing iOS podspec to path_provider_windows, which was necessary to publish it (since path_provider doesn't require 1.20+) - Requires path_provider_windows 0.0.2, not 0.0.1, in path_provider endorsement.
Windows implementation of the shared_preferences plugin, using Dart+FFI.
#3052) Stable channel still needs a 'pluginClass: none' to avoid "Invalid plugin specification" errors when parsing a Dart-only desktop plugin like this one. Fixes flutter/flutter#66158
shared_preferences supports versions older than 1.18, so this plugin needs the iOS stub to prevent breaking iOS projects via transitive dependencies when shared_preferences endorses the Windows implementation.
Moves the real implementation of path_provider_windows behind a conditional export, instead exporting a stub on platforms that don't support dart:ffi. This avoids build breakage in web projects that have transitive dependencies on path_provider (and thus path_provider_windows due to manual endorsement). This will no longer be necessary once flutter/flutter#52267 is fixed, since only Windows builds will ever need to have code-level dependency on path_provider_windows.
The fake didn't have getFolder, so if a test of something using path_provider_windows (such as shared_preferences_windows) had a fake that overrode getFolder, the analyzer would complain about overriding a non-existent method. This adds it to avoid that analyzer warning. It also fixes a minor issue introduced in the previous change, where folder.dart was accidentally made internal rather than public.
This makes globbing by tooling easier. Also fix the documentation for running them natively with the Android and iOS tool.
path_provider_windows 0.0.2 causes issues both for web projects and for projects built with Flutter 1.17 or earlier. This requires 0.0.4+ to ensure fixes for both issues are included.
Adds endorsement, and manual registration, of shared_preferences_windows. Fixes flutter/flutter#41719
) - Test script that runs on the device should go in `integration_test/`, e.g. `integration_test/local_auth_test.dart` - Driver script that runs on the host should go in `test_driver`, e.g. `test_driver/integration_test.dart`. The CI script has already been updated in - flutter/plugin_tools#105. - flutter/plugin_tools#108. See https://github.com/flutter/plugins/blob/master/packages/integration_test/README.md for more details.
This change removes the dependency that url_launcher_web has in package:platform_detect to achieve a null-safe gallery app. It also migrates the unit tests to run with flutter drive, instead of flutter test with --platform.
… 30 (#3040) This PR adds extra documentation to the canLaunch method, explaining that (from Android API 30) false is returned when the package visibility is not managed properly. Starting from Android API 30, apps should explicitly list which other apps it wants to query or interact with, by specifying them in the AndroidManifest.xml file. More information can be found in the Manage package visibility article in the Android documentation.
…e_selector plugin (#2995)
The previous push removed a class used for testing in the video_player package. This PR fixes tests to use the new class.
* Update main.dart Documentation typo. * Update CHANGELOG.md * Update pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?