Skip to content

Conversation

@snwagbata
Copy link
Owner

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Emmanuel Garcia and others added 30 commits February 2, 2021 16:35
macOS federated plugin implementations that contain no Dart code just
need their Dart SDK bumped in order to be considered nullsafe.
macOS federated plugin implementations that contain no Dart code just
need their Dart SDK bumped in order to be considered nullsafe.
Adds a prominent note to CONTRIBUTING.md about the new policy regarding PRs for plugins for which there is a Flutter Community Plus Plugins equivalent.
ffi 0.3.0 supports the new memory allocation model in Dart 2.12.0-259 and later.
* Check Permissions

* Format

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

* Update packages/wifi_info_flutter/wifi_info_flutter/android/src/main/java/io/flutter/plugins/wifi_info_flutter/WifiInfoFlutter.java

Co-authored-by: Maurice Parrish <bmparr@google.com>

Co-authored-by: Maurice Parrish <bmparr@google.com>
* Added stopRecordingVideo

* Removed deprecation and made stopRecordingVideo return void

* Removed unused import

* Revert pubspec change

* Updated documentation

* removed stopRecordingVideo

* Update packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

* fixed formatting

* Remove coverage folders

* Updated documentation

* updated version

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Migrate shared_preferences_windows to null safety
Migrate image_picker to null-safety
Migrating file_selector_interface to null-safety
Migrates shared_preferences_linux and shared_preferences_web to null-safety.
Flutter's video plugin can cause crashes after a closing a flutter view on simulator model iPhone X or higher

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
stuartmorgan-g and others added 29 commits March 25, 2021 10:27
…n types (#3754)

During the null-safety migration I accepted the auto-migrator use of as Future<T> to handle invokeMethod<T> returning a T?. I didn't realize that as does not actually do that kind of casting, and will fail with "type 'Future<T?>' is not a subtype of type 'Future<T>' in type cast".

There were no tests that exercised these methods in any way, so automated tests didn't catch the bug. This adds a minimal test that calls all of the non-void methods to ensure that they don't explode (and a TODO to backfill full unit tests of the entire method channel).

Fixes flutter/flutter#78426
Fixes flutter/flutter#78856
This enables to pass HTTP headers to VideoPlayerController.network.

Fixes: flutter/flutter#16466
Flutter master now creates NNBD code when running 'flutter create', so
the generated pubspec for build_all needs to use a compatible SDK
version. This updates from 2.0.0 to 2.12.0.

Also includes a test for this, which involved setting up tests for the
file, and doing some refactoring to make the command testable. As a
result, this fixes flutter/flutter#61049
(although more test backfill is needed).
TileOverlay was not copying its TileProvider. During the NNBD migration,
map object updates were refactored to share code, and in that
refactoring TileOverlay update construction was aligned with other map
objects to use clones, so certain operations involving TileOverlays
started dropping the TileProvider.

Fixes flutter/flutter#77500
Removes the override to use the legacy analysis, and fixes all resulting issues.

Part of flutter/flutter#76229
* Updates JS-interop package to google_maps ^5.1.0
* Breaking changes:
  * The property `icon` of a `Marker` cannot be `null`. Defaults to `BitmapDescriptor.defaultMarker`
  * The property `initialCameraPosition` of a `GoogleMapController` can't be `null`. It is also marked as `required`.
  * The parameter `creationId` of the `buildView` method cannot be `null` (this should be handled internally for users of the plugin)
  * Most of the Controller methods can't be called after `remove`/`dispose`. Calling these methods now will throw an Assertion error. Before it'd be a no-op, or a null-pointer exception.
The plugin was still using several beta version of Jetpack libraries
from 2 years ago. Updates to the latest stable version of each.

Fixes flutter/flutter#52742
Ensure that all auth replies, which are sent on an internal framework queue per documentation, are dispatched back to the main thread for handling, as all resulting operations (method channel callbacks, display of UI) are things that must be done on the main thread

In order to test this, sets up local_auth with XCTest-based tests, and adds the ability to inject a mock LAContext. (This does not do full unit test backfill, to limit the scope of the PR.)

Fixes flutter/flutter#47465
Removes the legacy analysis options override and fixes all resulting issues. This is a combination of dart fix and manual changes (mostly mechanical, but some small restructuring to address warnings more cleanly, such as creating typed structs from args when they are used repeatedly to avoid repeated casting, or making things that were unnecessarily public private).

One small opportunistic extra cleanup is that the handling of null-safety prerelease versions is removed, as any new plugin would be written null-safe from the start, so we no longer need to allow those versions.

Part of flutter/flutter#76229
@snwagbata snwagbata merged commit 21d8389 into snwagbata:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.