[Admin] Shipping category update#5723
Closed
loicginoux wants to merge 3 commits intosolidusio:mainfrom
Closed
Conversation
Now that new admin allow for searching them, we had to allow name attrribute to be searchable via ransack
github-actions
Bot
added
changelog:solidus_core
3 tasks
Contributor
|
This work has been migrated to #5817 and linter, conflicts and specs fixed and finished off. Thanks for this Loic :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows the work started on #5718 where Shipping categories creation was implemented. This PR is for updating a shipping category.
The issue is #5720
This PR includes the creation code as well because it was forked from the branche on #5718, so I'll keep this one in draft until the creation PR is merged.
This PR follows the code for editing tax categories from this PR #5697, I pretty much copy and adapt the code and added a spec (missing for tax categories edition). Talking about copying/duplicating code, should these basic crud actions be refactored to avoid duplication for other models ?
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: