[Admin] Shipping Categories edit/update#5817
Merged
MadelineCollier merged 1 commit intosolidusio:mainfrom Aug 12, 2024
Merged
Conversation
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5817 +/- ##
==========================================
- Coverage 88.80% 88.78% -0.02%
==========================================
Files 732 733 +1
Lines 17088 17114 +26
==========================================
+ Hits 15175 15195 +20
- Misses 1913 1919 +6 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR finishes off the excellent work by Loic that was left in draft on #5723
and includes an updated spec.
This PR follows the work started on #5718 where Shipping categories creation was implemented. This PR adds the edit/update functionality for shipping categories.
The issue is #5720
The attached video shows the functionality visually:
Screen.Recording.2024-08-08.at.7.14.00.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: