Conversation
Closed
rylev
force-pushed
the
wit-bindgen-0-7
branch
2 times, most recently
from
5c320ef to
fc5670a
Compare
fibonacci1729
approved these changes
Jun 22, 2023
rylev
changed the title
rylev
commented
Jun 27, 2023
| http = "0.2" | ||
| # The Spin SDK. | ||
| spin-sdk = { git = "https://github.com/fermyon/spin", tag = "v1.3.0" } | ||
| # Crate that generates Rust Wasm bindings from a WebAssembly interface. |
Collaborator
Author
There was a problem hiding this comment.
This deletion is only ok if the spin-sdk is aligned with the changes made in this PR. I'm unsure if this should be left for the bump of the SDK version or if it's ok to do this deletion now.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the Rust SDK to use wit-bindgen 0.8. This PR builds on top of #1594 so we'll want to merge that first (hence why this is a draft). This also supersedes #1424 which I will close.
A few notes:
In order to merge we need to: