-
Notifications
You must be signed in to change notification settings - Fork 123
feat: txn command to simulate #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d6ae5b to
0b4cb92
Compare
4da0f7e to
e958bed
Compare
578db4f to
7609f30
Compare
7609f30 to
4aafe3f
Compare
4aafe3f to
a0e3923
Compare
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some commits getting main merged in.
This PR looks like it's still a little ways away from being ready. Left some inline comments.
Would be a good idea to add tests for these commands too, from the outside-in.
|
Given the sensitivity of the sign command, I'd like to shift that work into a separate PR, so that we can get the other commands merged sooner, then follow up and take our time with the sign command. There should be litle to no need for the commands to be added together, so I think that'll be fine, but please lmk @willemneal if you think that'd be a problem. cc @janewang |
|
@leighmcculloch I've removed send because it has hard to test without a proper |
f9559c2 to
0be5d20
Compare
chadoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean code! I really like the tests. I have some questions, before I approve.
chadoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Part of #1265
Adds
txn simulate- simulate and assemble transactionFuture PR:
signer::Stellartrait and a defaultInMemoryimplementation needed fortxn signtxn sign- sign a given transactiontxn inspecttxn send- sends a signed transaction to the PRC (not useful without sign)Left