Skip to content

feat: use ledger in txn sign #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
willemneal wants to merge 85 commits into from
Closed

feat: use ledger in txn sign #1311

willemneal wants to merge 85 commits into from

Conversation

@willemneal
Copy link
Contributor

@willemneal willemneal commented May 2, 2024 •
edited
Loading

This depends on #1283 and #1278.

There is a lot of cleaning up to do and move some work into the ledger PR, but this currently works!

cargo r -- contract install --build-only --wasm ./target/wasm32-unknown-unknown/test-wasms/test_hello_world.wasm | 
cargo r -- txn simulate | 
cargo r -- txn sign --signer ledger | 
cargo r -- txn send

@elizabethengelman
Exploring how to interact with Ledger from rust code
4f8e15b
@elizabethengelman
WIP: get_public_key works, but needs to be cleaned up
50e5e5f
@elizabethengelman
Clean up: get_public_key
852114e
@elizabethengelman
Clean up: remove unused tests, etc
db1c976
@elizabethengelman
WIP: start the speculos emulator via docker
e24d8a6
@elizabethengelman
WIP: start speculos via docker and include some default elf files
0d1c9e7
@elizabethengelman
Allow for stopping the emulator
37b2a24
@elizabethengelman
Make get_public_key async
c68c40d 
so that is can use the ledger-transport::Exchange trait for the
transport which is async

using this trait allows us to use the Zemu transport which can connect
to the Speculos emulator
@elizabethengelman
WIP: Allow get_public_key to use Exchange trait to get the transport
1f51f3e 
still need to handle errors properly
@elizabethengelman
Pass transport into get_public_key_with_display_flag
b74f972
@elizabethengelman
Create a Ledger struct that takes in a generic that implements Exchange
7c1898b
@elizabethengelman
Add get_public_key_with_display_flag to Ledger implementation
d477ce8
@elizabethengelman
WIP: try to connect ledger struct to emulator transport intead of the…
6780f4d 
… ledger device
@elizabethengelman
WIP: connected to the emulator
b968fc7
@elizabethengelman
Add stellarNanoApp.elf
614e75b
@elizabethengelman
Cleanup
404dd46
@elizabethengelman
Add get_app_configuration fn
9c36b4c
@elizabethengelman
Add sign_transaction_hash fn
e39d95b
@elizabethengelman
Allow for enabling tx hash signing on the emulator
63bafad
@elizabethengelman
WIP - approve the tx on the device
0f96420
@elizabethengelman
WIP signing a tx
d249506
@elizabethengelman
wip sign tx
691102b
@elizabethengelman
not sure which is right
98a0ffa
@elizabethengelman
Making progress
28f999d 
i needed to look at the js implementation again (hw-app-str) - they have
a note that says to pass the `signatureBase` into the `signTransaction`
fn. I had forgotten about this. The `signatureBase` fn is defined in
js-stellar-base and is the value that should be sent to the network. it
is TransactionSignaturePayload.toXDR(). Which is also in the signer
train and i didn't notice it. 🙈
@elizabethengelman
cleanup
5f422ef
@elizabethengelman
Up the TransportZemuHttp timeout
b3a1a1c
@elizabethengelman
Cleanup
16ca7a5
@elizabethengelman
Update the expected sign_transaction response hex
1ea114f
@elizabethengelman
Fix tests
e2b6e0f
@elizabethengelman
Remove unused imports
692e659
elizabethengelman and others added 20 commits May 2, 2024 09:38
@elizabethengelman
Merge branch 'main' into feat/ledger-signing
ba0a75c
@willemneal
feat: --no-build command allows returning built transaction
4d20c27 
--sim-only for assembling transactions
@willemneal
feat: add txn subcommand
2043923
@elizabethengelman @willemneal
Merge branch 'main' into feat/ledger-signing
de934cf
@willemneal
Merge branch 'feat/txn-command' into feat/sign_with_ledger
df0161e
@willemneal
feat: first pass at using ledger to sign
8aa819c
@willemneal
fix: can't decode the return value from signing hash
b9516a4
@elizabethengelman
Cleanup
a5b6f9b
@elizabethengelman
Rename TransportZemuHttp -> EmulatorHttpTransport
8829da2 
since we're not actually using the zemu framework
@elizabethengelman
Update error handling
dfb5e3e
@elizabethengelman
Update error handling
feec1a0
@willemneal
feat: update and user errors
2ed4a1a
@willemneal
fix: clippy and fmt
9f57428
@willemneal
feat: add txn subcommand
578db4f
@willemneal
Merge branch 'feat/txn-command' into feat/sign_with_ledger
f0e0adc
@willemneal
feat: sign blob
4e54058
@elizabethengelman
Fix SignatureHint
40d978e
@elizabethengelman
Add get_transport fn back in
8026558
@willemneal
feat: initial signing working!
8d63c33
@willemneal
fix: fmt
201b034
@willemneal willemneal force-pushed the feat/sign_with_ledger branch from 09afd3c to 201b034 Compare May 3, 2024 19:16
@elizabethengelman elizabethengelman mentioned this pull request May 7, 2024
Merged
5 tasks
@willemneal
Copy link
Contributor Author

willemneal commented Jun 18, 2024

close in favor of: #1353

@willemneal willemneal closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willemneal @elizabethengelman @leighmcculloch