Skip to content

feat: add txn sign/send and ledger support #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
willemneal wants to merge 70 commits into from
Closed

feat: add txn sign/send and ledger support #1353

willemneal wants to merge 70 commits into from

Conversation

@willemneal
Copy link
Contributor

@willemneal willemneal commented May 31, 2024 •
edited
Loading

Currently relies on #1283.

Adds:

  • tx sign - use local key or ledger to sign a transaction (envelope)
  • tx send - submit a signed transaction envelope to the network
  • Stellar trait which handles the signing of transactions and auth-entries

willemneal and others added 30 commits May 8, 2024 16:26
@willemneal
feat: --no-build command allows returning built transaction
25849da 
--sim-only for assembling transactions
@willemneal
fix: clippy and fmt
4ea2d25
@willemneal
fix: address PR comments and skip install step for build only deploy
58daf6c
@willemneal
feat: add txn subcommand
a0e3923
@leighmcculloch
Merge branch 'main' into feat/txn-command
0fedbdb
@leighmcculloch
fix that should have been part of the merge
10ac181
@leighmcculloch
fix that should have been part of the merge
d1d6e33
@leighmcculloch
rename txn to tx
0cf656d
@willemneal
fix: remove tx sign
151026a
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
a43ac7a
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
64719b8
@willemneal
fix: print json for tx send
a3ee1aa
@willemneal
fix: only use stdin as input for txn simulate/send commands
588afd8
@willemneal
fix: remove txn inspect for now
8e0db60
@willemneal
fix: add back cargo alias
b2320d3
@willemneal
fix: docs
c8247b7
@willemneal
fix: fmt
b249242
@willemneal
fix: expect fund to work
60e3a9d
@willemneal
fix: make commands network runnable and fix tests
26346a2
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
5a13617
@willemneal
fix: fmt
1c3ec6d
@willemneal
fix: use default TestEnv
17e3ad2
@willemneal
fix: clippy
df35760
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
33a7055
@willemneal
fix: remove send as it is hard to test without sign
87f965c
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
7387c55
@willemneal
fix: docs
bb6d154
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
6fefb97
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
121d4b9
@willemneal
fix: simulate should return a Txn Envelope
fc3874c
@willemneal willemneal mentioned this pull request Jun 18, 2024
Closed
willemneal added 25 commits June 19, 2024 13:26
@willemneal
Merge remote-tracking branch 'origin/main' into feat/signer_with_send
027a3f4
@willemneal
WIP on feat/signer_with_send
139b1a7
@willemneal
Merge remote-tracking branch 'origin/main' into feat/signer_with_send
8bb8049
@willemneal
fix: fmt
4ad8d05
@willemneal
fix: tests
bf6bbe4
@willemneal
feat: add --yes to tests
e534c6e
@willemneal
fix: fmt
1795deb
@willemneal
fix: tests and clippy
c5c9077
@willemneal
fix: docs
328ab42
@willemneal
fix: tx sign test
7b9952c
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
f9559c2
@willemneal
Merge branch 'feat/txn-command' into feat/signer_with_send
7b950c9
@willemneal
Merge remote-tracking branch 'origin/main' into feat/txn-command
0be5d20
@willemneal
fix: tests and docs
c65f16c
@willemneal
Merge branch 'feat/txn-command' into feat/signer_with_send
3402ced
@willemneal
fix: use --check in place of --yes to prevent a breaking change
f45d38e
@willemneal
fix: docs and test
bc06dfb
@willemneal
fix: actually fix
b0d03d5
@willemneal
fix: Change config's check field to false
48da21a
@willemneal
fix: add fee and change to is-view for parsing tests
a8786d9
@willemneal
fix: turn off logs and change error
a71be6c
@willemneal
fix: rename sign_with_local_key to sign
5c5e641
@willemneal
feat: ensure that you cannot add a ledger key
449d61d
@willemneal
Merge remote-tracking branch 'origin/main' into feat/signer_with_send
ae1dbfe
@willemneal
Merge remote-tracking branch 'origin/main' into feat/signer_with_send
682034b
@willemneal
Copy link
Contributor Author

willemneal commented Jun 25, 2024

Closing in favor of #1406 as it is cleaner to review.

@willemneal willemneal closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fnando fnando fnando left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willemneal @fnando @leighmcculloch