Skip to content

Conversation

@Huanli-Meng Huanli-Meng requested a review from tuteng as a code owner September 1, 2021 09:13
@Huanli-Meng Huanli-Meng self-assigned this Sep 1, 2021
@Huanli-Meng Huanli-Meng requested review from a team as code owners September 1, 2021 09:13
@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for function-mesh ready!

🔨 Explore the source changes: d0c6acf

🔍 Inspect the deploy log: https://app.netlify.com/sites/function-mesh/deploys/614016e41187a90007cb0ffd

😎 Browse the preview: https://deploy-preview-95--function-mesh.netlify.app

| `ServiceAccountName` | Specify the name of the service account which is used to run Pulsar Functions or connectors in the Function Mesh Worker service.|
| `InitContainers` | The initialization containers belonging to a Pod. A typical use case could be using an initialization container to download a remote JAR to a local path. |
| `Sidecars` | Sidecar containers run together with the main function container in a Pod. |
| `BuiltinAutoscaler` | Specify the built-in autoscaling rules. <br> - CPU-based autoscaling: auto-scale the number of Pods based on the CPU usage (80%, 50%, or 20%). <br>- Memory-based autoscaling: auto-scale the number of Pods based on the memory usage (80%, 50%, or 20%). <br> If you configure the `BuiltinAutoscaler` field, you do not need to configure the `AutoScalingMetrics` and `AutoScalingBehavior` options and vice versa.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urfreespace since Function Mesh is built on Docusaurus, should we avoid using <br> in markdown tables?

Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the docs LGTM, but i would prefer to add an additional part to show user the options of BuiltinAutoscaler, ref: https://github.com/streamnative/function-mesh/blob/master/api/v1alpha1/hpa.go

@Huanli-Meng
Copy link
Contributor Author

Overall the docs LGTM, but i would prefer to add an additional part to show user the options of BuiltinAutoscaler, ref: https://github.com/streamnative/function-mesh/blob/master/api/v1alpha1/hpa.go

@freeznet Thanks for your comments. Doc is updated. PTAL again.

Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huanli-Meng Huanli-Meng merged commit ca55abf into main Sep 15, 2021
@Huanli-Meng Huanli-Meng deleted the functionmesh017 branch September 15, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants