Skip to content

use untyped yaml configuration as function or connector config #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
freeznet merged 13 commits into from
Aug 6, 2021
Merged

use untyped yaml configuration as function or connector config #233

freeznet merged 13 commits into from
Aug 6, 2021

Conversation

@freeznet
Copy link
Member

@freeznet freeznet commented Jul 21, 2021 •
edited
Loading

@freeznet freeznet requested a review from nlu90 as a code owner July 21, 2021 09:40
@freeznet freeznet self-assigned this Jul 21, 2021
@freeznet freeznet changed the title [WIP] use untyped yaml configuration as function or connector config use untyped yaml configuration as function or connector config Jul 22, 2021
@freeznet freeznet requested review from fantapsody and tuteng July 23, 2021 01:08
@freeznet
Copy link
Member Author

freeznet commented Jul 26, 2021

@tuteng @fantapsody PTAL when you have time, thanks.

fantapsody
fantapsody approved these changes Jul 27, 2021
View reviewed changes
controllers/spec/common.go
func getUserConfig(configs map[string]string) string {
func getUserConfig(configs *v1alpha1.Config) string {
if configs == nil {
return ""
Copy link
Contributor

@fantapsody fantapsody Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" might not be a valid json, will that be a problem?

Copy link
Member Author

@freeznet freeznet Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the userConfig in pulsar functions' proto FunctionDetails is defined as string, and the default value is "", so "" would be fine if there is no userConfig provided.

@freeznet freeznet force-pushed the freeznet/add-untyped-YAML-configuration-as-function-connector-config branch from cf6cd46 to b78380e Compare August 5, 2021 07:40
@freeznet freeznet merged commit feff2d8 into master Aug 6, 2021
@freeznet freeznet deleted the freeznet/add-untyped-YAML-configuration-as-function-connector-config branch August 6, 2021 00:57
@Huanli-Meng Huanli-Meng mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuteng tuteng tuteng approved these changes

@fantapsody fantapsody fantapsody approved these changes

@nlu90 nlu90 nlu90 approved these changes

Assignees

@freeznet freeznet

Labels

doc-added

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freeznet @tuteng @fantapsody @nlu90 @Huanli-Meng