render: switch to kube-core style file layout#106
Open
sttts wants to merge 101 commits intofeature-bootkubefrom
Open
render: switch to kube-core style file layout#106sttts wants to merge 101 commits intofeature-bootkubefrom
sttts wants to merge 101 commits intofeature-bootkubefrom
Conversation
…isabled When --cgroups-per-qos=false (default is true), kubelet sets pod container management to podContainerManagerNoop implementation and GetPodContainerName() returns '/' as cgroup parent (default cgroup root). (1) In case of 'systemd' cgroup driver, '/' is invalid parent as docker daemon expects '.slice' suffix and throws this error: 'cgroup-parent for systemd cgroup should be a valid slice named as \"xxx.slice\"' (https://github.com/moby/moby/blob/5fc12449d830ae9005138fb3d3782728fa8d137a/daemon/daemon_unix.go#L618) '/' corresponds to '-.slice' (root slice) in systemd but I don't think we want to assign root slice instead of runtime specific default value. In case of docker runtime, this will be 'system.slice' (https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L698) (2) In case of 'cgroupfs' cgroup driver, '/' is valid parent but I don't think we want to assign root instead of runtime specific default value. In case of docker runtime, this will be '/docker' (https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L695) Current fix will not set the cgroup parent when --cgroups-per-qos is disabled.
Mirroring was not mounting correctly in all cases, and manifest upload was not parallelized. Fix both issues.
This will enable an administrator to mirror an online release payload
to a local registry in preparation for running offline. It gathers the
images referenced by a release payload, mirrors them to the destination
registry, and then prints out the target payload image reference and
the prefix the CVO will use for offline.
$ oc adm release mirror --from=registry.svc.ci.openshift.org/openshift/origin-release:v4.0 \
--to registry.svc.ci.openshift.org/clayton-test-2/test
Skip the disruptive suite for now
Added integration tests Signed-off-by: Simo Sorce <simo@redhat.com>
Ignore errors caused by unkonwn scopes where it makes sense to do so.
Remove autogenerated docs folder and gitserver
Add a new `oc adm release mirror` command
UPSTREAM: 66617: Do not set cgroup parent when --cgroups-per-qos is disabled
…ize-ipfailover externalize ipfailover command
…ize-remaining-adm-commands externalize remaining adm commands
remove builder image dependencies on origin
…h bootkube phase 1
sttts
force-pushed
the
sttts-kube-core-file-layout
branch
from
27054ef to
da54cb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.