Skip to content

Add Install Metrics for TektonPipeline and TektonTrigger #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
khrm wants to merge 1 commit into from
Closed

Add Install Metrics for TektonPipeline and TektonTrigger #334

khrm wants to merge 1 commit into from

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Jun 22, 2021

Added an initial metrics implementation for TektonPipeline and
TektonTrigger.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 22, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2021
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2021
@khrm khrm force-pushed the metrics branch 2 times, most recently from 9e90ecb to e597a78 Compare June 22, 2021 14:02
@khrm khrm changed the title WIP: Add Install Metrics for TektonPipeline and TektonTrigger Add Install Metrics for TektonPipeline and TektonTrigger Jul 5, 2021
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2021
@nikhil-thomas
Copy link
Member

nikhil-thomas commented Aug 4, 2021

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@nikhil-thomas
Copy link
Member

nikhil-thomas commented Aug 4, 2021

@khrm
this patch will count each reconcile loop as a new install, wouldn't it. 🤔

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Aug 4, 2021

/hold
holding just to make sure that we all agree on what we count as an install. 🧑‍💻

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@tekton-robot
Copy link
Contributor

tekton-robot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [nikhil-thomas,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@savitaashture
Copy link
Contributor

savitaashture commented Aug 10, 2021 •
edited
Loading

@khrm Can we add logic for Dashboard also to count installation ?

@khrm
Copy link
Contributor Author

khrm commented Aug 12, 2021

@savitaashture Sure we can add that.

@khrm
Add Install Metrics for TektonPipeline and TektonTrigger
8dfb5b9 
Added an initial metrics implementation for TektonPipeline and
TektonTrigger.
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2021
@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 4, 2021

@khrm: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

vdemeester commented Sep 22, 2021

@khrm needs a rebase
@nikhil-thomas @tektoncd/operator-maintainers @tektoncd/operator-collaborators we should consider operator installation and component installation (pipeline, …) as two different metrics.

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Sep 23, 2021

@khrm needs a rebase
@nikhil-thomas @tektoncd/operator-maintainers @tektoncd/operator-collaborators we should consider operator installation and component installation (pipeline, …) as two different metrics.

yup, the operator installation metric will be taken care of by OLM.

With the recent refactoring in our reconcilers by @sm43 , we can differentiate between a component install, component upgrade and regular reconcile events. This will help us take care of the component specfic metrics better.

This was referenced Oct 11, 2021
Closed
Merged
@nikhil-thomas
Copy link
Member

nikhil-thomas commented Oct 12, 2021

closing this as #445 merged

@khrm khrm deleted the metrics branch June 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@khrm @nikhil-thomas @tekton-robot @savitaashture @vdemeester