Add Install and Upragde metrics for Pipeline and Triggers

[savitaashture]

Changes

PR address displaying of metrics when Pipeline and Triggers Install/Upgrade

PR incorporates changes from @khrm PR #334 and @sm43 PR https://github.com/sm43/tektoncd-operator/tree/metrics

/cc @vdemeester @nikhil-thomas @sm43 @khrm

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Operator exposes metrics to display Installation and Upgradation count for Tekton Pipeline and Triggers

Result

Pipeline Install and Upgrade count

Triggers Install and Upgrade count

[tekton-robot]

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: khrm.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Changes

PR address displaying of metrics when Pipeline and Triggers Install/Upgrade

PR incorporates changes from @khrm PR #334 and @sm43 PR https://github.com/sm43/tektoncd-operator/tree/metrics

Result

• Install of Pipeline and Triggers

curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep NewInstall
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="NewInstall",version="v0.28.0"} 1
100 15397    0 15397    0     0   8951      0 --:--:--  0:00:01 --:--:--  8946 tekton_operator_trigger_reconcile_count{status="NewInstall",version="v0.16.0"} 1

• Upgrade of Pipeline and Triggers

curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep Upgrade
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="Upgrade",version="v0.28.1"} 1
100 15390    0 15390    0     0  15624      0 --:--:-- --:--:-- --:--:-- 15608 tekton_operator_trigger_reconcile_count{status="Upgrade",version="v20211010-ae9b7ebdb7"} 1

/cc @vdemeester @nikhil-thomas @sm43 @khrm

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Operator exposes metrics to display Installation and Upgradation count for Tekton Pipeline and Triggers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[savitaashture]

@nikhil-thomas @sm43 addressed all the review comment provided in this PR #443

And its ready for another review
PTAL

[sm43]

/lgtm

[sm43]

we can also add the new configmap for validation in webhook

operator/pkg/webhook/webhook.go

Line 91 in 0870789

func NewConfigValidationController(ctx context.Context, cmw configmap.Watcher) *controller.Impl {

operator/pkg/webhook/webhook.go

Line 101 in 0870789

logging.ConfigMapName(): logging.NewConfigFromConfigMap,

[savitaashture]

we can also add the new configmap for validation in webhook

will this change relevant to this PR ?
If not lets handle in separate PR wdyt ?

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sm43]

/lgtm
/hold
@nikhil-thomas to take a look ! :)

[nikhil-thomas]

/lgtm

[nikhil-thomas]

Thanks 😸 @savitaashture
The pr description is 🔥 🥇 🧑‍💻 👍

[nikhil-thomas]

/lgtm /hold @nikhil-thomas to take a look ! :)

Thanks 🧑‍💻

[nikhil-thomas]

/hold cancel

[nikhil-thomas]

/approve
/lgtm