Skip to content

Add Install and Upragde metrics for Pipeline and Triggers #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
savitaashture wants to merge 1 commit into from
Closed

Add Install and Upragde metrics for Pipeline and Triggers #443

savitaashture wants to merge 1 commit into from

Conversation

@savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Oct 11, 2021

Changes

PR address displaying of metrics when Pipeline and Triggers Install/Upgrade

PR incorporates changes from @khrm PR #334 and @sm43 PR https://github.com/sm43/tektoncd-operator/tree/metrics

Result

  • Install of Pipeline and Triggers
curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep NewInstall
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="NewInstall",version="v0.28.0"} 1
100 15397    0 15397    0     0   8951      0 --:--:--  0:00:01 --:--:--  8946 tekton_operator_trigger_reconcile_count{status="NewInstall",version="v0.16.0"} 1
  • Upgrade of Pipeline and Triggers
curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep Upgrade
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="Upgrade",version="v0.28.1"} 1
100 15390    0 15390    0     0  15624      0 --:--:-- --:--:-- --:--:-- 15608 tekton_operator_trigger_reconcile_count{status="Upgrade",version="v20211010-ae9b7ebdb7"} 1

/cc @vdemeester @nikhil-thomas @sm43 @khrm

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Operator exposes metrics to display Installation and Upgradation count for Tekton Pipeline and Triggers

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2021
@tekton-robot
Copy link
Contributor

tekton-robot commented Oct 11, 2021

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: khrm.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Changes

PR address displaying of metrics when Pipeline and Triggers Install/Upgrade

PR incorporates changes from @khrm PR #334 and @sm43 PR https://github.com/sm43/tektoncd-operator/tree/metrics

Result

  • Install of Pipeline and Triggers
curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep NewInstall
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="NewInstall",version="v0.28.0"} 1
100 15397    0 15397    0     0   8951      0 --:--:--  0:00:01 --:--:--  8946 tekton_operator_trigger_reconcile_count{status="NewInstall",version="v0.16.0"} 1
  • Upgrade of Pipeline and Triggers
curl http://tekton-operator-openshift-operators.apps.ci-ln-0wlllrt-f76d1.origin-ci-int-gce.dev.openshift.com/metrics | grep Upgrade
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 tekton_operator_pipeline_reconcile_count{status="Upgrade",version="v0.28.1"} 1
100 15390    0 15390    0     0  15624      0 --:--:-- --:--:-- --:--:-- 15608 tekton_operator_trigger_reconcile_count{status="Upgrade",version="v20211010-ae9b7ebdb7"} 1

/cc @vdemeester @nikhil-thomas @sm43 @khrm

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Operator exposes metrics to display Installation and Upgradation count for Tekton Pipeline and Triggers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 11, 2021
@tekton-robot
Copy link
Contributor

tekton-robot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
nikhil-thomas
nikhil-thomas reviewed Oct 11, 2021
View reviewed changes
pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go
}

func (r *Reconciler) createInstallerSet(ctx context.Context, tp *v1alpha1.TektonPipeline) error {
func (r *Reconciler) updateTektonPipelineStatus(tp *v1alpha1.TektonPipeline, createdIs *v1alpha1.TektonInstallerSet) error {
Copy link
Member

@nikhil-thomas nikhil-thomas Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 👍

nikhil-thomas
nikhil-thomas reviewed Oct 11, 2021
View reviewed changes
pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go
Comment on lines -279 to -280
tp.Status.SetTektonInstallerSet(createdIs.Name)
tp.Status.SetVersion(r.releaseVersion)
Copy link
Member

@nikhil-thomas nikhil-thomas Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 👍

@savitaashture savitaashture force-pushed the install_upgrade_metrics branch from 5d40d83 to 03fd459 Compare October 11, 2021 08:43
@savitaashture savitaashture force-pushed the install_upgrade_metrics branch from 03fd459 to 432ead0 Compare October 11, 2021 09:18
nikhil-thomas
nikhil-thomas suggested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@nikhil-thomas nikhil-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you run bundle generation as well. steps

version: 1.6.0
previouse-version: 1.5.2

sm43
sm43 reviewed Oct 11, 2021
View reviewed changes
@savitaashture
Copy link
Contributor Author

savitaashture commented Oct 11, 2021

could you run bundle generation as well. steps

version: 1.6.0 previouse-version: 1.5.2

Ran bundle generation command and updated PR

@nikhil-thomas @sm43 closing this PR and raised new PR #445 where i did cherry pick of @sm43 and @khrm PR changes and addressed all the review comment over their

@savitaashture savitaashture mentioned this pull request Oct 11, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

+2 more reviewers

@sm43 sm43 sm43 left review comments

@nikhil-thomas nikhil-thomas nikhil-thomas requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@savitaashture @tekton-robot @vdemeester @nikhil-thomas @sm43