Skip to content

Conversation

@aiChaoSONG
Copy link

tested on several DUTs, works fine.

Chao Song added 2 commits April 20, 2021 10:56
Some test cases may want to collect kernel log from
boot, this patch adds a function to support to disable
kernel check point.

Test case should call disable_kernel_check_point instead
of setup_kernel_check_point to collect kernel log from
boot.

Signed-off-by: Chao Song <chao.song@linux.intel.com>
Signed-off-by: Chao Song <chao.song@linux.intel.com>
@aiChaoSONG aiChaoSONG requested a review from a team as a code owner April 20, 2021 03:08
@marc-hb marc-hb requested a review from plbossart April 22, 2021 23:21
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 22, 2021

Why not just check the logs from boot when no checkpoint is set?

The worse that can happen is: some test that should use a checkpoint forgets to set it, then it might fail because of earlier tests. That's a very easy lesson to learn and fix.

@aiChaoSONG
Copy link
Author

Why not just check the logs from boot when no checkpoint is set?

Previously, we have experience an issue which the test log is too big in stress test, that's why we only collect log output within the period of running test case, or under some condition, only collect logs from the latest iteration.
Now, I force every test case to explicit setup_kernel_check_point or disable_kernel_check_point in my journalctl PRs. die is not good, I agree with you, so #661 is a good fix.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have experience an issue which the test log is too big in stress test,

I didn't think about this, thanks for the info.

Copy link
Contributor

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Next step, we need to add this new test to first test case of all(or one of first)

@fredoh9 fredoh9 merged commit bf124ab into thesofproject:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants