Skip to content

Conversation

@keqiaozhang
Copy link
Contributor

runtime PM is not supported on BDW and BYT platforms, so we need
to set the kernel check point before the runtime PM support check
or the kernel check point will not be properly set up and cause
runtime PM check TIMEOUT on unsupported platforms.

Signed-off-by: Zhang Keqiao keqiao.zhang@intel.com

@keqiaozhang keqiaozhang requested a review from a team as a code owner April 22, 2021 06:41
Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change required

runtime PM is not supported on BDW and BYT platforms, so we need
to set the kernel check point before the runtime PM support check
or the kernel check point will not be properly set up and cause
runtime PM check TIMEOUT on unsupported platforms.

Signed-off-by: Zhang Keqiao <keqiao.zhang@intel.com>
Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@aiChaoSONG
Copy link

Merge to unlock daily test

@aiChaoSONG aiChaoSONG merged commit 4b6ba27 into thesofproject:main Apr 22, 2021
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 22, 2021

Can you explain how this was causing a timeout?

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 22, 2021

See also related #653

@aiChaoSONG
Copy link

aiChaoSONG commented Apr 23, 2021

Can you explain how this was causing a timeout?

sof-framework will grep keywords Pass/Fail/NA, these keywords are logged out in the hijack.sh, if we die earlier, these keywords never appear, sof-framework cannot find such keyword within timeout, so it thinks the test case is timeout.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 27, 2021

Ha yes, just like #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants