Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 23, 2021

One should never die in the "die handler", this means the final status
is not printed and causes a Jenkins timeout.

Fixes commit 18c7e61 ("sof-test: use journalctl for log
collection")

One should never die in the "die handler", this means the final status
is not printed and causes a Jenkins timeout.

Fixes commit 18c7e61 ("sof-test: use journalctl for log
collection")
@marc-hb marc-hb marked this pull request as ready for review April 23, 2021 00:38
@marc-hb marc-hb requested a review from a team as a code owner April 23, 2021 00:38
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

Informally approved by @aiChaoSONG in #653 (comment)

Can @fredoh9 or someone else approve? It's a very small but important fix that avoids TIMEOUTs blocking CI resources for a long time.

Copy link
Contributor

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants