From ical time zone#2
Merged
barelyknown merged 31 commits intoMay 10, 2016
Merged
Conversation
Adding namespacing to Rule in Readme to make it easier to run examples
Adding an option on schedule methods to include occurrences whose duration intersects a time window. Issue ice-cube-ruby#154 ice-cube-ruby#154
Unecessarily setting the start time search back to the start of the schedule for a spanned search, when in fact it simply needs to step back a duration.
The spans checks were incorrectly returning a hit when the end of the duration for an event ended on the same time as the start time checks. Allows occurring_between? method to now be simplifed to use the spanned check.
It seems true is no longer returned by any rule validation
Swapping the new spans parameter for an options hash to make the method calls more specific in their meaning.
Option to include prior occurrences with overlapping duration
Fix travis build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge current master to fix merge conflicts