Skip to content

Comments

More relation events#20

Closed
mjauvin wants to merge 30 commits intodevelopfrom
more-relation-events
Closed

More relation events#20
mjauvin wants to merge 30 commits intodevelopfrom
more-relation-events

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Mar 27, 2021 •
edited
Loading

mjauvin and others added 30 commits October 27, 2020 10:34
@mjauvin
add before/after save & create events
2d1f3f4
@mjauvin
add before/after associate/dissociate events
da8579d
@mjauvin
Revert "add before/after save & create events"
73ac6f0 
This reverts commit 2d1f3f4.
@mjauvin
do not make halting events
766ac61
@mjauvin
should not be halting events
8052d98
@mjauvin
return parent results for overriden parent methods
7f42aff
@mjauvin
override associate/dissociate and fire before/after events there
5762c7e
@mjauvin
do not pass true to Event::fire
93176f3
@mjauvin
use a trait to avoid code duplication
b33c08b
@mjauvin
remove unused class
b59cf61
@mjauvin
add example code in docblocks
5009e87
@mjauvin
add parent::detach results to event params
7e2b6e4
@mjauvin
add {before,after}Add events to AttachOneOrMany
4b015d4
@mjauvin
fix examples
4538d80
@mjauvin
fix typo
40215d0
@mjauvin
add remainging events
24870fc
@mjauvin
call parent::attach() instead of duplicating code here
5c73f26
@mjauvin
belongsto and morphto associate() methods have potentially different …
36a6344 
…arguments signature
@mjauvin
not needed, code moved to each relations
6d333b9
@mjauvin
properly pass the related model when firing the event
69019c0
@mjauvin
remove relatedModel event argument for dissociate()
70bff29
@mjauvin
properly pass the related model when firing the event
5142160
@mjauvin
use $model method argument, not $this->model
4601ae3
@mjauvin
fix related model
1812390
@mjauvin
Merge branch 'develop' into add-relation-events
d0a040f
@mjauvin
no result returned from parent
1c62d59
@mjauvin
fix typo
3d09007
@mjauvin
Merge branch 'develop' into add-relation-events
74e1e3a
@mjauvin @bennothommo
Update src/Database/Relations/BelongsToMany.php
51698b6 
Co-authored-by: Ben Thomson <git@alfreido.com>
@mjauvin
Merge branch 'develop' into more-relation-events
c746360
@LukeTowers LukeTowers added this to the v1.1.4 milestone Apr 1, 2021
@bennothommo bennothommo removed this from the v1.1.4 milestone May 21, 2021
@github-actions
Copy link

github-actions bot commented Jul 21, 2021

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@github-actions
Copy link

github-actions bot commented Sep 20, 2021

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers LukeTowers added this to the v1.1.8 milestone Nov 13, 2021
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers LukeTowers modified the milestones: v1.1.8, v1.1.9 Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@mjauvin
Copy link
Member Author

mjauvin commented Jun 4, 2022

Closed in favor of #78.

@mjauvin mjauvin closed this Jun 4, 2022
@mjauvin mjauvin removed this from the v1.1.9 milestone Jun 4, 2022
@mjauvin mjauvin mentioned this pull request Jun 5, 2022
Closed
@bennothommo bennothommo mentioned this pull request Jul 6, 2022
Merged
@mjauvin mjauvin deleted the more-relation-events branch July 27, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more relation events

3 participants

@mjauvin @LukeTowers @bennothommo