Skip to content

Comments

HasSortableRelations trait#78

Closed
mjauvin wants to merge 53 commits intowintercms:wip/1.2from
mjauvin:sortable-relation-trait
Closed

HasSortableRelations trait#78
mjauvin wants to merge 53 commits intowintercms:wip/1.2from
mjauvin:sortable-relation-trait

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Mar 29, 2022 •
edited
Loading

ref. octobercms/library#526

Fixes wintercms/winter#33

tobias-kuendig and others added 30 commits October 6, 2020 18:30
@tobias-kuendig
Added SortableRelation trait
4d312f8
@tobias-kuendig
Added space after function keyword
557b610
@mjauvin
add before/after save & create events
2d1f3f4
@mjauvin
add before/after associate/dissociate events
da8579d
@mjauvin
Revert "add before/after save & create events"
73ac6f0 
This reverts commit 2d1f3f4.
@mjauvin
do not make halting events
766ac61
@mjauvin
should not be halting events
8052d98
@mjauvin
return parent results for overriden parent methods
7f42aff
@mjauvin
override associate/dissociate and fire before/after events there
5762c7e
@mjauvin
do not pass true to Event::fire
93176f3
@mjauvin
use a trait to avoid code duplication
b33c08b
@mjauvin
remove unused class
b59cf61
@mjauvin
add example code in docblocks
5009e87
@mjauvin
add parent::detach results to event params
7e2b6e4
@mjauvin
add {before,after}Add events to AttachOneOrMany
4b015d4
@mjauvin
fix examples
4538d80
@mjauvin
fix typo
40215d0
@mjauvin
add remainging events
24870fc
@mjauvin
call parent::attach() instead of duplicating code here
5c73f26
@mjauvin
belongsto and morphto associate() methods have potentially different …
36a6344 
…arguments signature
@mjauvin
not needed, code moved to each relations
6d333b9
@mjauvin
properly pass the related model when firing the event
69019c0
@mjauvin
remove relatedModel event argument for dissociate()
70bff29
@mjauvin
properly pass the related model when firing the event
5142160
@mjauvin
use $model method argument, not $this->model
4601ae3
@mjauvin
fix related model
1812390
@mjauvin
Merge branch 'develop' into add-relation-events
d0a040f
@mjauvin
no result returned from parent
1c62d59
@mjauvin
fix typo
3d09007
@mjauvin
Merge branch 'develop' into add-relation-events
74e1e3a
@mjauvin mjauvin marked this pull request as draft April 1, 2022 12:20
@mjauvin mjauvin marked this pull request as ready for review April 1, 2022 17:11
LukeTowers
LukeTowers reviewed Apr 1, 2022
View reviewed changes
@mjauvin mjauvin changed the title Sortable relation trait HasSortableRelations trait Apr 1, 2022
@mjauvin mjauvin mentioned this pull request May 10, 2022
Closed
@mjauvin mjauvin removed this from the v1.2.0 milestone May 12, 2022
@mjauvin
Copy link
Member Author

mjauvin commented Jun 4, 2022

@LukeTowers I've changed the code path you didn't like and added an event instead to handle this gracefully for non-pivot based relations.

@mjauvin mjauvin mentioned this pull request Jun 4, 2022
Closed
@mjauvin mjauvin marked this pull request as draft June 5, 2022 13:13
@bennothommo bennothommo mentioned this pull request Jul 6, 2022
Merged
@bennothommo
Copy link
Member

bennothommo commented Jul 6, 2022

Replaced by #94 on an internal branch.

@bennothommo bennothommo closed this Jul 6, 2022
@mjauvin mjauvin mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers left review comments

Assignees

@mjauvin mjauvin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjauvin @LukeTowers @bennothommo @tobias-kuendig