Skip to content

Comments

[1.2] Sortable Relation trait#94

Merged
mjauvin merged 64 commits intodevelopfrom
wip/1.2-sortable-relation-trait
Jul 27, 2022
Merged

[1.2] Sortable Relation trait#94
mjauvin merged 64 commits intodevelopfrom
wip/1.2-sortable-relation-trait

Conversation

@bennothommo
Copy link
Member

@bennothommo bennothommo commented Jul 6, 2022

Replaces #78 with an internal branch, originally posted by @mjauvin.

ref. octobercms/library#526

tobias-kuendig and others added 30 commits October 6, 2020 18:30
@tobias-kuendig
Added SortableRelation trait
4d312f8
@tobias-kuendig
Added space after function keyword
557b610
@mjauvin
add before/after save & create events
2d1f3f4
@mjauvin
add before/after associate/dissociate events
da8579d
@mjauvin
Revert "add before/after save & create events"
73ac6f0 
This reverts commit 2d1f3f4.
@mjauvin
do not make halting events
766ac61
@mjauvin
should not be halting events
8052d98
@mjauvin
return parent results for overriden parent methods
7f42aff
@mjauvin
override associate/dissociate and fire before/after events there
5762c7e
@mjauvin
do not pass true to Event::fire
93176f3
@mjauvin
use a trait to avoid code duplication
b33c08b
@mjauvin
remove unused class
b59cf61
@mjauvin
add example code in docblocks
5009e87
@mjauvin
add parent::detach results to event params
7e2b6e4
@mjauvin
add {before,after}Add events to AttachOneOrMany
4b015d4
@mjauvin
fix examples
4538d80
@mjauvin
fix typo
40215d0
@mjauvin
add remainging events
24870fc
@mjauvin
call parent::attach() instead of duplicating code here
5c73f26
@mjauvin
belongsto and morphto associate() methods have potentially different …
36a6344 
…arguments signature
@mjauvin
not needed, code moved to each relations
6d333b9
@mjauvin
properly pass the related model when firing the event
69019c0
@mjauvin
remove relatedModel event argument for dissociate()
70bff29
@mjauvin
properly pass the related model when firing the event
5142160
@mjauvin
use $model method argument, not $this->model
4601ae3
@mjauvin
fix related model
1812390
@mjauvin
Merge branch 'develop' into add-relation-events
d0a040f
@mjauvin
no result returned from parent
1c62d59
@mjauvin
fix typo
3d09007
@mjauvin
Merge branch 'develop' into add-relation-events
74e1e3a
@bennothommo bennothommo changed the base branch from develop to wip/1.2 July 6, 2022 07:58
@bennothommo bennothommo added this to the v1.2.0 milestone Jul 6, 2022
@bennothommo bennothommo mentioned this pull request Jul 6, 2022
Closed
@mjauvin mjauvin modified the milestones: v1.2.0, 1.2.1 Jul 13, 2022
Base automatically changed from wip/1.2 to develop July 15, 2022 06:59
@mjauvin mjauvin requested a review from LukeTowers July 24, 2022 14:19
@mjauvin mjauvin self-assigned this Jul 24, 2022
@mjauvin
Copy link
Member

mjauvin commented Jul 24, 2022

@LukeTowers @bennothommo this has been used in production for over 3 months without any issues.

I would like to merge it.

@bennothommo
Copy link
Member Author

bennothommo commented Jul 25, 2022

@mjauvin If this is working with Winter 1.2, I'm happy for you to merge it.

@mjauvin
Copy link
Member

mjauvin commented Jul 25, 2022

@bennothommo @LukeTowers Other than the resizer tests failing for all commits in storm, I'm ready to merge this.

@mjauvin mjauvin merged commit bcbafd8 into develop Jul 27, 2022
@mjauvin mjauvin deleted the wip/1.2-sortable-relation-trait branch July 27, 2022 12:11
@mjauvin mjauvin mentioned this pull request Oct 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers Awaiting requested review from LukeTowers

Assignees

@mjauvin mjauvin

Labels

None yet

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bennothommo @mjauvin @tobias-kuendig