Skip to content

Fix: Update authentication guide to use .ts files instead of .mjs#10275

Merged
yanthomasdev merged 3 commits into
withastro:mainfrom
Keevh:patch-1
Dec 8, 2024
Merged

Fix: Update authentication guide to use .ts files instead of .mjs#10275
yanthomasdev merged 3 commits into
withastro:mainfrom
Keevh:patch-1

Conversation

@Keevh
Copy link
Copy Markdown
Contributor

@Keevh Keevh commented Dec 7, 2024

Description (required)

Updated the authentication guide to use .ts instead of .mjs for the configuration file. This aligns the documentation with the official library's README and prevents potential errors when users follow the guide.

Related issues & labels (optional)

First-time contributor to Astro Docs?

Yes! 🎉
Discord: keenivg

Updated the example in the authentication guide to use a `.ts` file instead of `.mjs`, aligning it with the official library's README. This change prevents potential errors when users follow the documentation.
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 7, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 07204a8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67561669070399000829824f
😎 Deploy Preview https://deploy-preview-10275--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/authentication.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Copy Markdown
Contributor

@apatel369 apatel369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @Kevin2606. Welcome to Team Docs! 🥳

Your changes are perfect.

Screenshot 2024-12-07 at 11 00 54 PM

Comment thread src/content/docs/en/guides/authentication.mdx Outdated
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kevin2606, welcome to Team Docs!

@yanthomasdev yanthomasdev merged commit aef8651 into withastro:main Dec 8, 2024
@Keevh Keevh deleted the patch-1 branch December 9, 2024 03:17
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 19, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Dec 19, 2024
* i18n(fr): Update `guides/authentification.mdx` from #10275

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/cms/cloudcannon.mdx` from #10335

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/configuring-astro.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/data-fetching.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/google-cloud.mdx` from #10338

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/vercel.mdx` from #10330

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `reference/configuring-astro.mdx` about "Le fichier de configuration d'Astro"

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auth-astro instructions show using a .mjs

4 participants