Skip to content

Add dockerhub URL to registry examples in Google Cloud Deploy Guide#10338

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
trueberryless:add-dockerhub-to-registry-examples
Dec 11, 2024
Merged

Add dockerhub URL to registry examples in Google Cloud Deploy Guide#10338
sarah11918 merged 2 commits into
withastro:mainfrom
trueberryless:add-dockerhub-to-registry-examples

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

Description (required)

Since Docker Hub is mentioned in the text above, I think it would make sense to include the Registry URL in the examples below...

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 11, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 639bf4b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6759870b4337710008cdb08e
😎 Deploy Preview https://deploy-preview-10338--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 11, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/google-cloud.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 11, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@sarah11918 sarah11918 merged commit 5605d67 into withastro:main Dec 11, 2024
@trueberryless trueberryless deleted the add-dockerhub-to-registry-examples branch December 11, 2024 12:52
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Dec 11, 2024
yanthomasdev added a commit that referenced this pull request Dec 16, 2024
* update google-cloud.mdx

* fix link

* many fixes

* more fixes

* last fix

* update with changes from #10338

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 19, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Dec 19, 2024
* i18n(fr): Update `guides/authentification.mdx` from #10275

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/cms/cloudcannon.mdx` from #10335

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/configuring-astro.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/data-fetching.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/google-cloud.mdx` from #10338

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/vercel.mdx` from #10330

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `reference/configuring-astro.mdx` about "Le fichier de configuration d'Astro"

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants