Skip to content

Add PackageManagerTabs to guides/deploy/vercel.mdx#10330

Merged
TheOtterlord merged 6 commits into
withastro:mainfrom
trueberryless:update-vercel-commands
Dec 12, 2024
Merged

Add PackageManagerTabs to guides/deploy/vercel.mdx#10330
TheOtterlord merged 6 commits into
withastro:mainfrom
trueberryless:update-vercel-commands

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

Description (required)

Add pnpm and yarn commands via PackageManagerTabs component.

!!! IMPORTANT !!!

I'm working from mobile, so commands are not tested, not sure if pnpm and yarn add is correct. Pls review!

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 10, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7c2000d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675b14a59f2030000883af09
😎 Deploy Preview https://deploy-preview-10330--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 10, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/vercel.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment thread src/content/docs/en/guides/deploy/vercel.mdx Outdated
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Dec 11, 2024

Just a heads up that in future, if this isn't a super urgent fix, then it would be more helpful if you waited to PR until you knew what you were adding were correct! 😅

It's less helpful to put something on a maintainer's plate when you haven't yet taken the time to ensure accuracy, and I'm not sure why this PR was made at this stage when it clearly could have waited until you were able to verify the contents.

Have you had a chance to verify the content?

Comment thread src/content/docs/en/guides/deploy/vercel.mdx
@trueberryless
Copy link
Copy Markdown
Contributor Author

Just a heads up that in future, if this isn't a super urgent fix, then it would be more helpful if you waited to PR until you knew what you were adding were correct! 😅

Yeah, I'm really sorry about. I'm just too enthusiastic about Astro, so I work from mobile... Gonna stop such things in the future!

Have you had a chance to verify the content?

I guess I could have asked Mr Google what the pnpm and yarn equivalents are...

Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one small change to sync the commands with our vercel integration guide.

Comment thread src/content/docs/en/guides/deploy/vercel.mdx
@TheOtterlord TheOtterlord merged commit b58739e into withastro:main Dec 12, 2024
@trueberryless trueberryless deleted the update-vercel-commands branch December 12, 2024 21:17
yanthomasdev added a commit to trueberryless/withastro-docs that referenced this pull request Dec 16, 2024
yanthomasdev added a commit that referenced this pull request Dec 16, 2024
* Update vercel.mdx

* Add changes from #10330

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 19, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Dec 19, 2024
* i18n(fr): Update `guides/authentification.mdx` from #10275

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/cms/cloudcannon.mdx` from #10335

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/configuring-astro.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/data-fetching.mdx` from #9240 (v5)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/google-cloud.mdx` from #10338

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/deploy/vercel.mdx` from #10330

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `reference/configuring-astro.mdx` about "Le fichier de configuration d'Astro"

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

* Update src/content/docs/fr/guides/configuring-astro.mdx

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants