fix(tutorial): prevent Typescript error + tiny data reordering#12532
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Merged
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Oct 12, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Oct 12, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Oct 12, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Oct 12, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
ArmandPhilippot
added a commit
that referenced
this pull request
Oct 12, 2025
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
yanthomasdev
added a commit
that referenced
this pull request
Nov 24, 2025
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
index.astrorequires optional chaining and thesetAttributevalue should be a string.This is flagged by Typescript because the default preset is
strictand we don't tell people to switch tobasicsin Unit 1.2.Note that this is no longer an issue once moved to
scripts/menu.jsbut I kept the same code to avoid any confusion or extra wording.MarkdownPostLayout.astrofrontmatter data in Unit 5.3: Unit 4-2 and Unit 4-3 use a different order, we had thefrontmatter.descriptionbetween thedateand theauthor.Except the Typescript error, this is mostly nits... But this could be confusing for beginners when they check if their files are correct!
Related issues & labels (optional)
code snippet updateblog-tutorial-demobranches updates: