i18n(de): refactor: remove inconsistencies (tutorial)#12778
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
I found another inconsistency, although there unfortunately might be more, as the tutorial consists of loads of pages.
Side note: I used to expect it to be done by the end of October, but it clearly took way longer than I anticipated… maybe it still might not be done by December! 🫤
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
|
I think we should still attempt to get the tutorial merged. Trying to perfect this would take weeks if not months, and if there are major inconsistencies we will find them eventually! I think the state this is in is good enough. |
I mean, I used search and replace with some RegEx to make it more manageable. We do not aim for perfection, remember if we spot something we can fix it later as well, doesn't have to be perfect from the beginning, well-done is enough...
I think we could think about merging after this is merged, but if you want to take a closer look, feel free. From my side it's approved ✅ |
|
As Sarah wrote in our Contributing Guide:
Let's get this full German tutorial merged @trueberryless @randomguy-2650 @louisescher! I believe there might be a few things to update from recent PRs that you can handle easily with one more PR, and then we should be good to go. |
Description
Go through all common inconsistencies in Discord (i18n-de channel) and apply them to all wrong occurances.
Also update with changes from #12763.
I basically did all 3 points from #12502 (comment)
Please review @randomguy-2650 and maybe @louisescher if you both have the time.
After merging into
de/tutorialbranch, I think we may be able to merge, I didn't find any other changes to the English tutorial since 1. October with a little script 🤷