Skip to content

i18n(ko-KR): update Korean UI strings#41

Merged
Adammatthiesen merged 3 commits into
withstudiocms:mainfrom
jsparkdev:ko-ui-string
Apr 8, 2025
Merged

i18n(ko-KR): update Korean UI strings#41
Adammatthiesen merged 3 commits into
withstudiocms:mainfrom
jsparkdev:ko-ui-string

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 8, 2025

Description

add Korean translation config and update Korean UI strings

Summary by CodeRabbit

  • New Features
    • Introduced comprehensive Korean language support, enabling native Korean speakers to experience a fully localized interface. This update incorporates Korean translations for site titles, documentation, search functionalities, error messages, and various UI elements, ensuring a smoother multilingual experience.

@jsparkdev jsparkdev requested a review from a team as a code owner April 8, 2025 07:54
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2025

Walkthrough

This pull request enables support for the Korean language. The configuration files (astro.config.mts and lunaria.config.ts) are updated to include active Korean locale entries. Additionally, a new JSON file (src/content/i18n/ko.json) is added to provide Korean translations for various labels, messages, and user interface elements used throughout the application.

Changes

File(s) Change Summary
astro.config.mts, lunaria.config.ts Uncomments and adds the Korean entry (ko: { label: '한국어', lang: 'ko' } in astro.config.mts and { label: '한국어', lang: 'ko', parameters: { tag: 'ko' } } in lunaria.config.ts) to the locales configuration.
src/content/i18n/ko.json Adds a new JSON file containing key-value pairs for Korean translations of site titles, documentation labels, error messages, etc.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Config
    participant TranslationLoader
    participant UI

    User->>UI: Select Korean locale (ko)
    UI->>Config: Request available locales
    Config-->>UI: Return locales list (includes ko)
    UI->>TranslationLoader: Load Korean translations
    TranslationLoader-->>UI: Provide translations from ko.json
    UI->>User: Render UI with Korean texts
Loading

Suggested reviewers

  • Adammatthiesen

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5782d6 and 50146c8.

📒 Files selected for processing (1)
  • lunaria.config.ts (1 hunks)
🔇 Additional comments (1)
lunaria.config.ts (1)

80-86: Korean locale successfully added!

The Korean locale has been properly configured following the same structure as other active locales in the configuration file. The language code "ko" and the corresponding tag are correctly specified according to internationalization standards.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 8, 2025
@Adammatthiesen
Copy link
Copy Markdown
Member

(You can ignore the knip workflow, its failing since it requires an org token to run)

Copy link
Copy Markdown
Member

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we also get the Lunaria config updated to also enable the locale on the i18n tracker?

Copy link
Copy Markdown
Member

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @jsparkdev ! Welcome to the StudioCMS Contributor Squad!

@jsparkdev
Copy link
Copy Markdown
Contributor Author

@Adammatthiesen Thank you for your welcome!

@Adammatthiesen Adammatthiesen merged commit 0ad378a into withstudiocms:main Apr 8, 2025
6 checks passed
@jsparkdev jsparkdev deleted the ko-ui-string branch April 8, 2025 08:15
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants