Skip to content

i18n(ko-KR): update sidebar#43

Merged
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:sidebar
Apr 8, 2025
Merged

i18n(ko-KR): update sidebar#43
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:sidebar

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 8, 2025

Description

  • update sidebar into Korean string

Summary by CodeRabbit

  • New Features
    • Introduced Korean language support by providing localized translations for various interface elements.
    • Expanded language options to include Korean, offering a more accessible experience for users.

@jsparkdev jsparkdev requested a review from a team as a code owner April 8, 2025 08:46
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2025

Walkthrough

This update introduces Korean localization support. A new JSON file (ko.json) is added to the sidebar, which contains key-value pairs for various user interface strings in Korean. Additionally, the Translations constant and its derived type in translate.ts have been updated to include the new language code 'ko'. These changes extend internationalization support without modifying the underlying translation logic.

Changes

File(s) Change Summary
starlight-sidebar/ko.json Added new JSON localization file for Korean containing key-value pairs (e.g., “배우기”, “패키지 목록”, etc.)
starlight-sidebar/translate.ts Updated the Translations constant and its type definition to include 'ko' alongside existing languages

Possibly related PRs

Suggested labels

i18n

Suggested reviewers

  • Adammatthiesen
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@studiocms-no-reply
Copy link
Copy Markdown
Member

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
starlight-sidebar/ko.json Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
starlight-sidebar/ko.json (1)

17-17: Minor note on file formatting.

There's a trailing empty line at the end of the file. While this doesn't affect functionality, you might want to ensure this is consistent with other language JSON files in the project.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ad378a and 1a136eb.

📒 Files selected for processing (2)
  • starlight-sidebar/ko.json (1 hunks)
  • starlight-sidebar/translate.ts (1 hunks)
🔇 Additional comments (2)
starlight-sidebar/ko.json (1)

1-16: Well-structured Korean translation file!

The Korean translation JSON file is properly formatted and contains translations for all necessary sidebar elements. The additions support the internationalization objectives stated in the PR.

starlight-sidebar/translate.ts (1)

7-7: Korean language support correctly implemented.

The addition of 'ko' to the Translations array is the correct approach to enable Korean language support, following the pattern established in the file's documentation. This change works together with the newly added ko.json file to extend the application's internationalization capabilities.

@Adammatthiesen Adammatthiesen merged commit 5e288ac into withstudiocms:main Apr 8, 2025
6 of 7 checks passed
@jsparkdev jsparkdev deleted the sidebar branch April 18, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants