Skip to content

i18n(ko-KR): update ko.json#95

Merged
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:t
Apr 20, 2025
Merged

i18n(ko-KR): update ko.json#95
Adammatthiesen merged 1 commit into
withstudiocms:mainfrom
jsparkdev:t

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 20, 2025

Description

Summary by CodeRabbit

  • New Features

    • Added new Korean translations for guide and upgrade-related topics in the sidebar.
    • Introduced a new Korean localization for quick update instructions.
  • Improvements

    • Updated the Korean translation for "utils" in the sidebar for greater clarity.
    • Enhanced JSON syntax consistency in localization files.

@jsparkdev jsparkdev requested a review from a team as a code owner April 20, 2025 06:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2025

Walkthrough

This update modifies Korean localization files for both general content and the sidebar. In src/content/i18n/ko.json, a new key for a quick update message is added, and a missing trailing comma is inserted for JSON validity. In src/starlight-sidebar/ko.json, the translation for "utils" is updated, and five new keys related to guides and upgrades are introduced with their Korean translations. No changes are made to exported or public entities; only localization strings are affected.

Changes

File(s) Change Summary
src/content/i18n/ko.json Added "quick-update" key with Korean translation; fixed missing trailing comma for JSON validity.
src/starlight-sidebar/ko.json Updated "utils" translation; added five new guide/upgrade-related keys with Korean translations.

Possibly related PRs

Suggested labels

i18n

Suggested reviewers

  • Adammatthiesen

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61dbc5c and bda13b2.

📒 Files selected for processing (2)
  • src/content/i18n/ko.json (1 hunks)
  • src/starlight-sidebar/ko.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Run Starlight Link Check
🔇 Additional comments (4)
src/content/i18n/ko.json (2)

47-47: Valid JSON syntax: trailing comma added
The addition of the comma after "docsearch.noResultsScreen.reportMissingResultsLinkText" restores valid JSON formatting.


48-48: Verify new i18n key usage and consistency
You’ve added "quick-update" here—please ensure:

  1. A matching key exists in the default (e.g., en.json) file.
  2. All components reference i18n('quick-update') correctly.
  3. The Korean copy aligns with the English source string.
src/starlight-sidebar/ko.json (2)

8-8: Review updated translation for “utils”
You’ve changed "utils" to "유틸리티 & 도우미". Please confirm that:

  • This phrasing matches the terminology used elsewhere (e.g., other docs or UI).
  • The ampersand usage (&) follows your localization style guide.

15-20: Verify new sidebar entries and translations
Five new keys were introduced (auto-gen, topic-guides, database, upgrade, version, latest). Ensure that:

  1. Corresponding entries exist in the default language file.
  2. These keys are wired into the sidebar component.
  3. The Korean translations accurately reflect the English originals.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@studiocms-no-reply
Copy link
Copy Markdown
Member

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
src/content/i18n/ko.json Localization changed, will be marked as complete.
src/starlight-sidebar/ko.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Adammatthiesen Adammatthiesen merged commit 0ea37e7 into withstudiocms:main Apr 20, 2025
8 checks passed
@jsparkdev jsparkdev deleted the t branch April 20, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants