Conversation
jkmassel
approved these changes
Oct 29, 2025
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
Looks sound overall. I welcome @jkmassel 's feedback on the inclusion of SVGView.
I'm not a big fan of it overall, but I think it works and it moves us forward for now. We can revisit this one later when we're implementing this on the Android side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
How?
Switch to SVGView, which is a more modern framework, and as lenient as a browser when it comes to parsing SVG. It supports shorten coordinates like
5.5h3a.5.5that are common in Gutenberg.One of the design choices was to enforce a particular fill color (in order to support dark mode). It works great for nearly all icons, but I found only one exception so far – "Animoto Embed". This icon uses multiple colors, and doesn't look ideal (see screenshots below). We can simply hardcode a different icon for it if we want. Note: you need to merge #204 to test the embed variants.
Testing Instructions
Screenshots or screencast
Known Issues (Identified in the scope of this PR)
(these are fixed by #199)
Screenshots (
core/embedvariants)Before:
After:
