Native Inserter: Improve ordering of blocks and more#206
Merged
kean merged 12 commits intotask/blocks-with-predefined-parametersfrom Oct 29, 2025
Merged
Conversation
kean
commented
Oct 29, 2025
| * Optimized for mobile usage patterns where users frequently create content | ||
| * with text, media from device cameras, and visual formatting. | ||
| */ | ||
| const MOST_USED_BLOCKS = [ |
Contributor
Author
There was a problem hiding this comment.
Feedback on MOST_USED_BLOCKS and BLOCK_ORDER_BY_CATEGORY is welcome.
I expect to refine it further in the scope of CMM-915: Add first-class support for Jetpack blocks.
Member
Contributor
Author
There was a problem hiding this comment.
Thanks for the links!
devOnly( code ), – this could be interesting. I added CMM-917: Show core/code block only for developers.
dcalhoun
approved these changes
Oct 29, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Tested well for me. Feels really good.
| * Optimized for mobile usage patterns where users frequently create content | ||
| * with text, media from device cameras, and visual formatting. | ||
| */ | ||
| const MOST_USED_BLOCKS = [ |
Member
Comment on lines
34
to
38
| Text(name) | ||
| .font(.headline) | ||
| .foregroundStyle(Color.secondary) | ||
| .padding(.leading, padding) | ||
| .frame(maxWidth: .infinity, alignment: .leading) |
Member
There was a problem hiding this comment.
WDYT about making the semantics of this element a heading? It could be convenient when navigating via VoiceOver.
Contributor
Author
There was a problem hiding this comment.
I'm going to keep track of accessibly issues in CMM-916: Improve accessibility and address them at the end. Thanks!
kean
deleted the
task/improve-block-ordering-and-support-for-other-stuff
branch
kean
added a commit
that referenced
this pull request
Oct 29, 2025
* Add support for block variants * Rename BlockType * Capitlize ID * Update src/components/native-block-inserter-button/index.jsx Co-authored-by: David Calhoun <github@davidcalhoun.me> * Native Inserter: Improve ordering of blocks and more (#206) * Add a note about serializeBlocksForNative * Remove now redundant core/missing check * Move ordering to the JS land * Further refactoring * Pass displayName for Text * Localize categories * Extend most used blocks * Add gbk-most-used as a separate section * Add support for disabling blocks * Collapse long sections * Update the order of embeds * Fix linter errors --------- Co-authored-by: David Calhoun <github@davidcalhoun.me>
kean
added a commit
that referenced
this pull request
Oct 29, 2025
* Implement block insertion * Load bridge only if enabled * Refactor the component that handles insertion * Fix inserter not working when selected from tilte * Fix an issue with editor not restoring focus when block inserter is dismissed * Fix order of inserts * Native Inserter: Add support for block variants (#204) * Add support for block variants * Rename BlockType * Capitlize ID * Update src/components/native-block-inserter-button/index.jsx Co-authored-by: David Calhoun <github@davidcalhoun.me> * Native Inserter: Improve ordering of blocks and more (#206) * Add a note about serializeBlocksForNative * Remove now redundant core/missing check * Move ordering to the JS land * Further refactoring * Pass displayName for Text * Localize categories * Extend most used blocks * Add gbk-most-used as a separate section * Add support for disabling blocks * Collapse long sections * Update the order of embeds * Fix linter errors --------- Co-authored-by: David Calhoun <github@davidcalhoun.me> --------- Co-authored-by: David Calhoun <github@davidcalhoun.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes CMM-875: Establish the mobile-specific order for blocks.
How?
isDisabled)core/missingblock support (no longer needed since Native Inserter: Implement block insertion #199)MOST_USED_BLOCKSsection (gbk-most-used)Screenshots or screencast
Note: screenshots are pre #205