[Tooling] Report Firebase Test Failures as Buildkite Annotations#17581
Merged
AliSoftware merged 5 commits intotrunkfrom Nov 30, 2022
Merged
[Tooling] Report Firebase Test Failures as Buildkite Annotations#17581AliSoftware merged 5 commits intotrunkfrom
AliSoftware merged 5 commits intotrunkfrom
Conversation
…uildkite" This reverts commit 3b2d8b8.
AliSoftware
commented
Nov 30, 2022
Comment on lines
-10
to
+12
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 6.0' | ||
| # gem 'fastlane-plugin-wpmreleasetoolkit', '~> 6.0' | ||
| #gem 'fastlane-plugin-wpmreleasetoolkit', path: '../../release-toolkit' | ||
| #gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', branch: '…' | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', branch: 'firebase-test-return-url' |
Contributor
Author
There was a problem hiding this comment.
🚧 TODO: revert this and point to the new version of the release-toolkit once wordpress-mobile/release-toolkit#430 lands and we published a new release.
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 8437c09 | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 8437c09 | |
ParaskP7
approved these changes
Nov 30, 2022
Contributor
There was a problem hiding this comment.
This is awesome @AliSoftware , I really longed for this!
I reviewed and tested both, this and its associated release-toolkit PR, everything LGTM! 🥇 ❤️ 🚀
Contributor
Author
|
Dammit, too many tabs open, and I confused two PRs and hit Merge on the wrong one 😓 Reverting the merge in #17583 before I can re-open a PR re-preparing everything again afterwards… #not-my-day |
This was referenced Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR catches test failures happening when running Instrumented Tests in Firebase, and add a Buildkite annotation at the top of the failed build so it's way easier to jump to the details of the test failure on Firebase Console.
How it looks
This is how the annotation appears on Buildkite if an Instrumented Test failure occurs:
To Test
Observe that the intentional failure that I've forced to happen in 3b2d8b8 indeed generated a Buildkite annotation (see screenshot above) — while a successful Instrumented Tests run like the one at the HEAD of this branch doesn't.
TODO
release-toolkitonce it has landed, then remove the "Not Ready for Merge" label