Add ability for the caller to handle the firebase failures#430
Merged
AliSoftware merged 3 commits intotrunkfrom Nov 30, 2022
Merged
Add ability for the caller to handle the firebase failures#430AliSoftware merged 3 commits intotrunkfrom
AliSoftware merged 3 commits intotrunkfrom
Conversation
Especially so they can use `buildkite-annotate` and/or do other steps to report the failure before bailing
AliSoftware
force-pushed
the
firebase-test-return-url
branch
from
de1a465 to
d1eff86
Compare
1 task
ParaskP7
approved these changes
Nov 30, 2022
ParaskP7
left a comment
ParaskP7
left a comment
There was a problem hiding this comment.
This is awesome @AliSoftware , I really longed for this!
I reviewed and tested both, this and its associated WPAndroid PR, everything LGTM! 🥇 ❤️ 🚀
AliSoftware
commented
Nov 30, 2022
Contributor
Author
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Small typo in CHANGELOG
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially so they can use
buildkite-annotateand/or do other steps to report the failure before bailingTo Test
See this PR in WordPress-Android where this new feature has been tested and used, in particular: