[Tooling] Report Firebase Test Failures as Buildkite Annotations (take 2)#17584
Merged
AliSoftware merged 5 commits intotrunkfrom Dec 1, 2022
Merged
Conversation
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 8e2c00a | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 8e2c00a | |
Contributor
Author
Once Automattic/peril-settings#103 lands , if someone could remove-then-re-add the "Do Not Merge" label to this PR in order to re-trigger Peril on it and ensure it will guarantee preventing accidental merge of it, that would be nice 🙂 |
1 task
AliSoftware
force-pushed
the
tooling/firebase-test-failure-annotation-take2
branch
from
c0e377b to
b59e8e8
Compare
AliSoftware
commented
Nov 30, 2022
Gemfile
Outdated
Comment on lines
+10
to
+12
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 6.0' | ||
| # gem 'fastlane-plugin-wpmreleasetoolkit', '~> 6.0' | ||
| #gem 'fastlane-plugin-wpmreleasetoolkit', path: '../../release-toolkit' | ||
| #gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', branch: '…' | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', branch: 'trunk' |
Contributor
Author
There was a problem hiding this comment.
release-toolkit after we published it in RubyGems.
jkmassel
added
[Status] Not Ready for Merge
and removed
[Status] Not Ready for Merge
labels
So that in case a first iteration of the Instrumented Tests failed and generated an annotation, and the failed build gets retried, we make sure the previous failure annotation is then removed if the retry succeeds.
AliSoftware
deleted the
tooling/firebase-test-failure-annotation-take2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17581 for details
Why?
I accidentally merged #17581 too soon, before a new release for the
release-toolkitwas done and I could point to it.So I reverted the early merge in #17583, and here we are in this PR, preparing the exact same changes again (that were already approved in #17581), but this time we will make sure to wait for a new release before merging it… right?
TODO
release-toolkitonce one gets published, then remove the Not Ready for Merge label once done.