Add a media settings view for images (#1527)#3
Closed
jkv wants to merge 20 commits intowordpress-mobile:masterfrom
Closed
Add a media settings view for images (#1527)#3jkv wants to merge 20 commits intowordpress-mobile:masterfrom
jkv wants to merge 20 commits intowordpress-mobile:masterfrom
Conversation
* Cleaned up header * Changed constants from #define to CGFloat const * Removed unnecessary delegate
It was helpful while developing it, but now it's mostly annoying
Added more formatting and links to trac and style guide
We were using "postid", but wp.getPages uses "page_id" That means pageID was always nil on `+ [Page findOrCreateWithBlog:andPageID:]`, and pages were recreated on every sync refs wordpress-mobile#1578
We're disabling this until it's more stable
In some cases (display_errors Off?) media uploads that run out of memory would return an empty response. Treat that as a failed upload so it can be retried/discarded
If we get a XML-RPC error 425, that means the password was correct, but two step authentication is enabled, and we need to switch to an app specific password
…sword would disappear after scrolling the view in landscape orientation.
Ref: http://ios.trac.wordpress.org/ticket/1527 Added a media settings view that allows a user to manage the caption, link, alignment, position and size of an image that has been uploaded from the iOS device. Changes made to the media settings on other devices (web, android, etc) are handled. Example, you can upload an image from your phone, edit the size and caption on the web site and then open the post on the phone and make changes to the settings again. If there are any additional attributes added to the image or anchor elements they will not be lost. Note: Images uploaded from other devices are still not displayed in the attachments for a post. * Updating media no longer blindly replaces text, handles when the user makes changes to the HTML manually or from another device, and keeps attributes in place that the media settings can not handle * Changed all the media notifications to be sent in the same way. The notification object is always the sender and Media and MediaSettings are sent inside the userInfo dctionary. * MediaSettings ** Class method createMediaSettingsForUrl can be used to pull out the HTML for a media object matching the URL. This HTML will include the caption, a and img elements. ** 5 properties are exposed that can be set from the new MediaSettingsViewController (captionText, alignment, customWidth, customHeight, linkHref). Making changes to any of these will only replace/update the text in the media HTML and leave all other attributes alone.
ghost
assigned
koke
added a commit
that referenced
this pull request
May 22, 2013
Fixing bug where clicking on the notification detail header would result in a blank page being opened
frosty
added a commit
that referenced
this pull request
Mar 14, 2017
…deletion Media Library #3: Deletion
frosty
pushed a commit
that referenced
this pull request
Jan 8, 2018
jklausa
pushed a commit
that referenced
this pull request
Oct 10, 2018
…n-option Update visibility criteria of Plugins option
jkmassel
pushed a commit
that referenced
this pull request
Oct 24, 2018
…n-option Update visibility criteria of Plugins option
4 tasks
kean
added a commit
that referenced
this pull request
Jun 20, 2023
…maning-deprecated-uttype-apis Drop iOS 14 Support: Update remaining UTType usages (#3)
kean
added a commit
that referenced
this pull request
Jul 7, 2023
…cation-warnings-io12jc912j Drop iOS 14 Support: Address UIButton API deprecations (#3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: http://ios.trac.wordpress.org/ticket/1527
Added a media settings view that allows a user to manage the caption, link, alignment, position and size of an image that has been uploaded from the iOS device. Changes made to the media settings on other devices (web, android, etc) are handled. Example, you can upload an image from your phone, edit the size and caption on the web site and then open the post on the phone and make changes to the settings again. If there are any additional attributes added to the image or anchor elements they will not be lost.
Note: Images uploaded from other devices are still not displayed in the attachments for a post.
makes changes to the HTML manually or from another device, and keeps
attributes in place that the media settings can not handle
notification object is always the sender and Media and MediaSettings
are sent inside the userInfo dctionary.
** Class method createMediaSettingsForUrl can be used to pull out the
HTML for a media object matching the URL. This HTML will include the
caption, a and img elements.
** 5 properties are exposed that can be set from the new
MediaSettingsViewController (captionText, alignment, customWidth,
customHeight, linkHref). Making changes to any of these will only
replace/update the text in the media HTML and leave all other
attributes alone.