Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Asdjky
Copy link
Contributor

@Asdjky Asdjky commented May 27, 2021

Tesla Miniball maximum now properly enforced.
Miniball power output no longer tied to zap range.
Minimum zap range increased to 2.
Grounding Rod bonus range increased by 1.
Tesla Coils no longer cause zaps to jump.
Coil cooldown restrictions actually work now.
Research/money gain adjusted to compensate for cooldown restrictions.

General Documentation

Intent of your Pull Request

This makes some of the Tesla's mechanics less weird, more predictable, and actually impactful. Currently you are extremely unlikely to ever see the Tesla's power output be above 1.7mW (unless you upgrade the Tesla Coils for a straight 100%/200%/etc bonus). This is because of some weird mechanics and decisions on how power generation is calculated. The changes in this PR will mean a roughly 50% increase in power output for the Tesla which will put it a bit under what a default TEG generates.
I've tested these changes and with the default setup power output is always at a minimum of 1.7mW with spikes up to 2.5mW and 3.4mW.

Why is this change good for the game?

The Tesla's mechanics are easier to reason about and opportunities for experimenting with different Tesla setups are now possible.

Wiki Documentation

Briefly describe your PR and the impacts of it, in layman's terms.

The Tesla's mechanics are now more consistent and impactful. Miniball power generation has been increased because it is no longer tied to zap range. Tesla Coils that are zapped no longer cause a jump because that behavior was putting every coil onto cooldown with a single zap. Tesla Coils now go on cooldown when zapped and can't be zapped again until a short duration (8 seconds, decreased by better parts).

What should players be aware of when it comes to the changes your PR is implementing?

Casual players who are just interested in having power be setup don't need to be concerned with this change. A default Tesla setup will still work perfectly fine for the station. However, enterprising players will be able to make changes to the Tesla's default setup and see improved results to power output.

What general grouping does this PR fall under?

Engineering rebalancing.

Are there any aspects of the PR that you would like us not to mention on the Wiki?

No

If there are any numerical values involved in your PR that will be relevant to a player, please note them here.

Grounding Rods now work 1 tile further than they previously did making the default Tesla setup completely safe.
Standard Tesla Coils now generate the full amount of power per zap instead of anywhere from 1-50% of full power. This results in a roughly 50% increase in power output overall. Research Tesla Coils still incur a 95% power loss in exchange for increased research generation.
Tesla Coil cooldowns are now enforced. This means that when a coil is zapped it goes on cooldown and cannot be zapped before the cooldown is up. Level 1 coils have a cooldown of 8 seconds. Coils can be upgraded with capacitors to reduce the cooldown by 2 seconds per capacitor level.

Changelog

Tesla mechanics tweaked to be more consistent, resulting in a roughly 50% increase in power output and more setup variety.

🆑
bugfix: Tesla Miniball maximum now properly enforced
bugfix: Tesla Coil cooldowns now actually work
tweak: Miniball power output no longer tied to zap range
tweak: Minimum Miniball zap range increased to 2 (was 1)
tweak: Grounding Rod bonus range increase to 3 (was 2)
tweak: Tesla Coils no longer cause zaps to jump
/:cl:

Tesla Miniball maximum now properly enforced.
Miniball power output no longer tied to zap range.
Zap range standardized across objects and minimum range increased to 2.
Tesla Coils no longer cause zaps to jump.
Coil cooldown restrictions actually work now.
Research/money gain adjusted to compensate for cooldown restrictions.
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Tweak This PR contains changes to the game. labels May 27, 2021
@Cartlord
Copy link
Contributor

Cartlord commented Jun 6, 2021

I don't know what the hell you did, but the tesla - fully set up - keeps blowing holes in the PA room on Box.

@Asdjky
Copy link
Contributor Author

Asdjky commented Jun 6, 2021

I don't know what the hell you did, but the tesla - fully set up - keeps blowing holes in the PA room on Box.

Yea I know what's happening here. It's a combination of me messing up the range check for grounding rods (which was easily fixed) and the cooldowns for tesla coils now properly working. Now that cooldowns actually work there are two positions the Tesla can be in where there are no valid targets in range except the station itself. I'll think about how I should resolve this, I really don't want to do any map changes though.

@adamsong
Copy link
Contributor

adamsong commented Jun 7, 2021

This has caused the tesla to blow holes in engineering for multiple rounds now. This needs either fixed or unmerged until it is.

@Asdjky
Copy link
Contributor Author

Asdjky commented Jun 7, 2021

This has caused the tesla to blow holes in engineering for multiple rounds now. This needs either fixed or unmerged until it is.

I didn't realize this was testmerged, I interpreted Cartlord's comment in a different way. I'll get it fixed right away. Sorry about that.

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 13, 2021

Hows the test merges gone on this?

@Asdjky
Copy link
Contributor Author

Asdjky commented Jun 25, 2021

Hows the test merges gone on this?

The first few days were a bit rough since I broke it, but after that everything looks good. I haven't personally seen anybody do non-default setups but everything with the default setup looks good in terms of power generation and coil mechanics working as intended.

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 92e694a
Pull Request: 2f84df9
Server: da56d524b85eeabf513b808c3ed6a8c9df605f9a

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 6eac6b8
Pull Request: 2f84df9
Server: 92b18435786db50501d15b57a7d0f399158dcce7

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 6eac6b8
Pull Request: 2f84df9
Server: 4cf045dcc80de3751ed501a3fdf71a161b4b6078

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 09dc773
Pull Request: 2f84df9
Server: 8ce5531e4aa90f730f2881ca15125742069cc3b7

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 50e22d9
Pull Request: 2f84df9
Server: cfbef971e39f756f57c6351ccba16176fb7ca9b7

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: d244ed8
Pull Request: 2f84df9
Server: c9dd238bda1b13104771876231c7f061360f117a

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: b34fc83
Pull Request: 2f84df9
Server: 99a8136a2c3ea2386b7417cadce313eef7205037

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 51d15f3
Pull Request: 2f84df9
Server: 08a5b01226a862a638855658a1fcb349f2180bdf

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: faf404b
Pull Request: 2f84df9
Server: 261ac2b415670d9615de140a821f0aed25f45412

@adamsong adamsong added the TESTMERGED This PR is currently live in a test merge. label Jul 2, 2021
@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: dfdf9d2
Pull Request: 2f84df9
Server: a57b89a5cefc62a3059460567fc50d2b23efa5f5

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: dfdf9d2
Pull Request: 2f84df9
Server: d723368c137b9977e75b3e26dfb321c788297cdd

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 24d1f23
Pull Request: 2f84df9
Server: 1c84e2f8d3d922d24bcc92d7edb9ce9e32d5252e

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: e581b72
Pull Request: 2f84df9
Server: fc7122cf9f35688fd96d1b459cc1c9b61682e752

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 1befeb3
Pull Request: 2f84df9
Server: 87f7ce98fbe6e2119e87704ba716dc7213e89bd9

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: bfcf8bf
Pull Request: 2f84df9
Server: e56275b82d8a1b0a3a432a233629ac206864f83a

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 074dc71
Pull Request: 2f84df9
Server: e10404c9a10c2ee7f917b59885fa18ede7f0435a

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: aeb34a7
Pull Request: 2f84df9
Server: 3fc96da3fe7b326106f45bec9fcd29d2afa4b3c4

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 5b96721
Pull Request: 2f84df9
Server: 0e5c469765b215fb6c9c7efe7e82d2ab360f0212

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: a2b0d80
Pull Request: 2f84df9
Server: 48ff5736e8e42a68fceb7e361203ebf0fa1bbeb2

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: 75e2418
Pull Request: 2f84df9
Server: a573d4fda4232a30130441438b8607ed178df93e

@Yogbot-13
Copy link
Contributor

Test Merge Updated

Server Instance

main

Merged By

JamieD12

Revision

Origin: b0848ca
Pull Request: 2f84df9
Server: 46c827dc9eeae1ddda6382961b987de97833563a

@JamieD1 JamieD1 merged commit fbcf464 into yogstation13:master Jul 9, 2021
Yogbot-13 added a commit that referenced this pull request Jul 9, 2021
@Asdjky Asdjky deleted the fix_tesla_madness branch July 9, 2021 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs TESTMERGED This PR is currently live in a test merge. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants