Voice Announcement System for AIs and Captains #11548

monster860 · 2021-06-05T10:44:07Z

Do not merge or testmerge without deploying this website PR first yogstation13/Yogstation.net#2

General Documentation

Intent of your Pull Request

This pull request allows AIs and captains to make voice announcements using their microphones. The way this works is that when they press the button to initiate the voice announcement, a page is opened in a browser that allows them to record a short 30 second voice announcement and upload it to the server. I totally didn't make this PR for the sole purpose of being able to say nya. In all seriousness, I do not play captain or AI very much so you won't be subjected to that.

Here's an example of what it sounds like:

AIs (has a voice filter)
Non-AIs

AI filter and echo effect processing occurs on browser side

Why is this change good for the game?

It allows for players to create creative, immersive announcements.

Wiki Documentation

Briefly describe your PR and the impacts of it, in layman's terms.

It adds the ability for captain or AI to do voice announcements.

What should players be aware of when it comes to the changes your PR is implementing?

Don't abuse this system please.

What general grouping does this PR fall under?

Command I guess

Are there any aspects of the PR that you would like us not to mention on the Wiki?

No

If there are any numerical values involved in your PR that will be relevant to a player, please note them here.

The limit is 30 seconds.

Moderation note

There is a limit of 30 seconds to the audio, and the file size is limited to 120 KB. In practice the uploaded files are usually smaller, averaging maybe 20-30 KB. The website records at 20 Kb/s
All audio clips are copied to the logs folder when they are played. The person's ckey is part of the filename. The Get Server Logs or Get Current Logs can be used to download the audio clip
A CANCEL button is pushed into the chat for admins when the sound clip is played. Pressing this button will immediately stop the sound for everyone.
There is a short offset between when admins hear the sound, and when everyone else hears it. This allows admins to cancel the audio before anyone hears an offensive sound clip.
A job ban type has been added to allow admins to ban people from this feature.

Changelog

🆑
add: Adds the ability to make voice announcements with a microphone via communications console or AI. Do not abuse this.
/:cl:

code/datums/world_topic.dm

boba247 · 2021-06-05T13:51:12Z

Is it possible to create a ban specifically for this function?

monster860 · 2021-06-05T13:53:07Z

Is it possible to create a ban specifically for this function?

I am already one step ahead of you, I've already done this. Aaaand I forgot to mention it in the PR body

Bibby0110 · 2021-06-05T14:37:18Z

this is going to be horrible

i love it

Jarod1200 · 2021-06-05T14:52:58Z

Is there a preferences toggle that lets you not hear them if you want

TheLinuxOS · 2021-06-05T15:12:04Z

Monster you are now my favorite coder

Marmio64 · 2021-06-05T17:15:14Z

Greetings, crew, this is your captain and I would just like to say that I hate all lig- [BWOINK] [BWOINK] [FREEZED] [BANNED]

alexkar598 · 2021-06-05T17:27:22Z

Not going to lie, this is amazing but I'm not a fan of the idea of voice in ss13

Hopekz · 2021-06-05T17:43:50Z

Good original PR.

Can we maybe get an option to type out text for the recording? So that people can read along like a normal announcement

Not going to lie, this is amazing but I'm not a fan of the idea of voice in ss13

We've had voice in ss13, it was all pre recorded but present nonetheless.

N3D6 · 2021-06-05T18:27:37Z

I don't think this is a great idea.
This is 100% gonna be abused, I can't be convinced otherwise.

Bibby0110 · 2021-06-05T18:40:20Z

so voicechat integration next?

SaltyToastr · 2021-06-05T19:21:10Z

I cannot express how much of a bad idea this is. we already have the cho*per greifers, now this? Now people will just spam shit in the annoucement system. The argument of "Oh admins will just ban them, duh!" is pretty invalid, as there aren't going to be admins on 24/7.

TheLinuxOS · 2021-06-05T19:27:53Z

I cannot express how much of a bad idea this is. we already have the cho*per greifers, now this? Now people will just spam shit in the annoucement system. The argument of "Oh admins will just ban them, duh!" is pretty invalid, as there aren't going to be admins on 24/7.

Admins will hear whatever is being said 3.5 seconds before players do and can cancel it at any time. And you can disable it in prefrences if you dont want to hear it when admins arent on to deal with it. Literally no one can be griefed by this if they dont want to be

code/_onclick/hud/ai.dm

code/datums/voice_announcements.dm

code/game/machinery/computer/communications.dm

code/datums/world_topic.dm

code/datums/voice_announcements.dm

alexkar598 · 2021-06-05T19:19:03Z

code/datums/voice_announcements.dm

+			var/turf/T = get_turf(M)
+			if(T.z == z_level)
+				SEND_SOUND(M, sound2)
+	sleep(30)


Wouldn't it make more sense to do this?

Suggested change

sleep(30)

sleep(duration + 5 SECONDS)

That's an unreasonably long wait time IMO

I'm not too sure about having it played for everyone before admins get to hear the full message tho

admins get to hear bad words before everyone else, hit cancel button, sure they'll get a message cut off halfway but whatever right?

code/datums/voice_announcements.dm

ghost · 2021-06-05T21:39:37Z

This PR is a terrible idea and I love it, merge this shit.

maxion12345 · 2021-06-06T03:27:51Z

Lots of arguments against this are "oh people could say N word with it!"

you know how many ways you could insert a racial slur into this game? voice annoucements would probably be the most tame of them ngl. I think it's an interesting idea. I, for one, am going to be using it to broadcast shitty text to speech as an AI, it'll be fuckin hiliarious

Bibby0110 · 2021-06-13T13:42:35Z

Lots of arguments against this are "oh people could say N word with it!"

yeah true it's just a bit different when a 12 year old child drills the N-word into your skull at 10000% volume while you're attempting to stuff the clown down disposals.

But jokes aside this will only really go wrong when there are no admins, the mega-conservative approach would be to just disable this when there are no admins on if you really want to be sure

N3D6 · 2021-06-14T00:30:08Z

ngl observing this a bit while testmerged makes it seem like an even worse idea
only thing i've seen it used for so far is unfunny shitposting
if you mute it because you don't wanna hear this stuff if an important announcement is made you're not gonna hear shit of it so if you don't wanna miss something probably important you have to just keep it unmuted and cope with the unfunny
shit idea

Tipy1802 · 2021-06-22T20:12:08Z

ngl observing this a bit while testmerged makes it seem like an even worse idea
only thing i've seen it used for so far is unfunny shitposting
if you mute it because you don't wanna hear this stuff if an important announcement is made you're not gonna hear shit of it so if you don't wanna miss something probably important you have to just keep it unmuted and cope with the unfunny
shit idea

So the same as AI vox?

Voice Announcement System

e31ec37

monster860 requested a review from a team June 5, 2021 10:44

Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Javascript This PR contains javascript code. labels Jun 5, 2021

Fixes shit the linter complained about

217036e

github-actions bot added Admin This PR affects administrators Config Config files need to be changed on the host for this to work tgui This PR affects TGUI labels Jun 5, 2021

AshCorr suggested changes Jun 5, 2021

View reviewed changes

code/datums/world_topic.dm Show resolved Hide resolved

Uses topic instead of JSON files

922a34e

alexkar598 suggested changes Jun 5, 2021

View reviewed changes

fixes alex's problems

9c9155f

alexkar598 reviewed Jun 5, 2021

View reviewed changes

code/datums/voice_announcements.dm Outdated Show resolved Hide resolved

monster860 added 2 commits June 5, 2021 17:13

use /dev/urandom on linux

1506dc0

GenerateToken

7b8545e

update the config in theory

3c25f6c

Allow downloading sounds via Get Server Logs

74ec94d

This was referenced Jun 15, 2021

Op-tables just don't sync to OpComps sometimes #11599

Closed

"Charcoal stylus" has no sprite #11600

Closed

Sgtdevel mentioned this pull request Jun 23, 2021

Cloning cannot use multiple pods to clone. #11629

Closed

ghost mentioned this pull request Jun 29, 2021

Cyborgs can't deconstruct tables or racks. #11659

Closed

JamieD1 merged commit 7013fa3 into yogstation13:master Jul 1, 2021

Yogbot-13 added a commit that referenced this pull request Jul 1, 2021

Automatic changelog generation #11548 [ci skip]

da3e982

Uh oh!

Voice Announcement System for AIs and Captains #11548

Voice Announcement System for AIs and Captains #11548

Uh oh!

Conversation

monster860 commented Jun 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Do not merge or testmerge without deploying this website PR first yogstation13/Yogstation.net#2

General Documentation

Intent of your Pull Request

Why is this change good for the game?

Wiki Documentation

Briefly describe your PR and the impacts of it, in layman's terms.

What should players be aware of when it comes to the changes your PR is implementing?

What general grouping does this PR fall under?

Are there any aspects of the PR that you would like us not to mention on the Wiki?

If there are any numerical values involved in your PR that will be relevant to a player, please note them here.

Moderation note

Changelog

Uh oh!

Uh oh!

boba247 commented Jun 5, 2021

Uh oh!

monster860 commented Jun 5, 2021

Uh oh!

Bibby0110 commented Jun 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jarod1200 commented Jun 5, 2021

Uh oh!

TheLinuxOS commented Jun 5, 2021

Uh oh!

Marmio64 commented Jun 5, 2021

Uh oh!

alexkar598 commented Jun 5, 2021

Uh oh!

Hopekz commented Jun 5, 2021

Uh oh!

N3D6 commented Jun 5, 2021

Uh oh!

Bibby0110 commented Jun 5, 2021

Uh oh!

SaltyToastr commented Jun 5, 2021

Uh oh!

TheLinuxOS commented Jun 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexkar598 Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

monster860 Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

alexkar598 Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

Bibby0110 Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jun 5, 2021

Uh oh!

maxion12345 commented Jun 6, 2021

Uh oh!

Bibby0110 commented Jun 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

N3D6 commented Jun 14, 2021

Uh oh!

Tipy1802 commented Jun 22, 2021

Uh oh!

Reviewers

monster860 commented Jun 5, 2021 •

edited

Loading

Bibby0110 commented Jun 5, 2021 •

edited

Loading

Bibby0110 commented Jun 13, 2021 •

edited

Loading