Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nmajask
Copy link
Contributor

@nmajask nmajask commented Jul 14, 2021

Github documenting your Pull Request

Adds a new job, a Brig Physician. Their job is to treat prisoners and officers, preform surgeries, recover dead officers, and generally help sec with medical issues. Basically, they are a mining medic but for sec. While they have access to the brig and have a flash they are not a security officer and should help officers, not do their job for them. They can not arrest people or hunt for antags unless the situation is dire (ie nukies are attacking). They should follow the orders of the HoS and warden when it comes to security matters, and the CMO when it comes to medical ones. This job is based on the one on Bee Station, so look to that for a more in depth description of the job.

Why?

  1. Many times I or other people have wanted to work the infirmary in the brig
  2. There are many reasons sec would need medical staff in the brig, giving you plenty to do (implant removal, pacifying people, giving officers cybernetics, treating people, ect.)
  3. Could serve as a nice way for people who normally play medical to try working with sec
  4. Could help reduce the stress of sec, as there would be more people to help you
  5. Brig Physicians have been jobs on other servers, like Beestation

Job Details

Here is an overview of the attributes

  • By default, only one slot is open round start
  • They have access to most of the brig and perma, the access that mining medics have for medical, and (on skeleton crew) access to the sec office Removed as requested by adamsong
  • It is part of sec on the occupation select menu
  • Part of medsci in game and is payed from the medical budget
  • The heads which the brig physician are under is the CMO and HoS Removed as requested by adamsong
  • They require a character to be at least 24 (like most med staff)

One issue with the Brig Physician is how does it work with antags. For example, Paradise and the original Brig Physician on Bee has it function as a sec officer (mindshielded and exempt from antag roles), while the current implementation of the Bee version makes it act as a normal role. For this PR, I did the latter and just had it function as a normal job, but if the former is preferred I can implement that.

Equipment

When staring, they have:

  • A unique jacket and hat
  • Med hud glasses
  • A flash (For protection) Removed as requested by Anvilman6 and many others
  • A roller bed
  • A mindshield As requested by Tipy Removed as requested by adamsong
    BPstartingequipment

Here is a picture of them wearing their starting gear:
bplandmark

In the infirmary, there is a secure locker. within it is:

  • A bag containing different outfits
  • A medical PDA cartridge
  • A medsec radio
  • A medical belt
  • A crew pinpointer
  • A crew monitor
  • A box of bodybags
  • An anesthetic tank Added as requested by Anvilman6
  • A medical mask Added as requested by Anvilman6

Map Changes

There are numerus changes to maps, but as I have no experience with mapping, some changes might not work or could be bad. First off, I added landmarks for the brig physician (usually in the brig infirmary), but more importantly I changed most brig infirmaries. Most of the time, the changes are as follows:

  • Adding a surgery table, op computer, and tools
  • Adding the brig physicians locker and a blood freezer
  • Adding a sleeper and medical vender (maybe a bit too much to add)
  • Removing some of the morgue trays

Here is a more in depth list of changes with pictures:

Box: Basically what I said before, but with the removal of a bed to make space
boxchanges

Meta: Has the most changed, adds a new room that is the office for the Brig Physician that replaces some of maints that contains a morgue tray, Brig Physician's locker, blood freezer, and camera console
metachanges

Delta: Mainly separated the Infirmary from the brig
deltachanges

Kilo: Basically the same as the changes to box
kilochanges

Misc Changes

  • Warden has brig physician access (as it is part of the brig, they should have access to it)
  • New PDA icon for the mining medic
  • Mining medic starts with their jacket on (for consistency)

Issues/To Do

Wiki Documentation

Assuming this PR doesn't immediately get shot down, ill begin working on a wiki page for the Brig Physician on my user page on the wiki, This can be transferred to its own page if it gets full merged and can act as a temporary guide if its test merged. Other than that, there are the map changes, misc changes, and a bunch of other thing that would need to be updated.

Changelog

🆑
rscadd: Added the Brig Physician as a new job
tweak: Tweaked the infirmary in the brig in multiple maps
tweak: Mining medics now start with their jackets, have a custom PDA color, and have their own hat
/:cl:

nmajask added 13 commits May 11, 2021 19:44
added more detail to sigtech icon
new tourist and clerk icons
I uploaded the wrong file
Adds new signal technician and paramedic hud icons and reverts clerk's back, all requested by grimm-hollowknight
Adds brig physicians as a new job. There are a lot of changes, but in short:
- Added the job and many required things for it to work
- Edited maps to add lockers, landmarks, and update the brig medbay
- Added new clothing, PDAs, IDs, ect.
- Fixed some stuff I forget to change on some maps
- Added new landmark icons
@nmajask nmajask requested review from a team as code owners July 14, 2021 23:48
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Sprites This PR has spriting changes Tweak This PR contains changes to the game. labels Jul 14, 2021
@Bibby0110
Copy link
Contributor

Sleeper is big

@ynot01
Copy link
Contributor

ynot01 commented Jul 15, 2021

Sleeper is big

Also, how is this intended to work with validhunting aspect?

@nmajask
Copy link
Contributor Author

nmajask commented Jul 15, 2021

Sleeper is big

As alexkar said in #development-public, it would most likely only used on prisoners and would require sec to cooperate to work, so it probably wouldn't be too big.

Also, how is this intended to work with validhunting aspect?

If your talking about can they arrest, the way I intended it to work was that they weren't allowed to do security's job for them and should only use the provided flash for protection, but that is more of a rules issue that the staff would have to decide if this gets merged.

@Bibby0110
Copy link
Contributor

I don’t like the idea of separating sec and medical by giving sec almost equal equipment to medbay

@nmajask
Copy link
Contributor Author

nmajask commented Jul 15, 2021

I don’t like the idea of separating sec and medical by giving sec almost equal equipment to medbay

The brig has no where near the amount of equipment as medbay, they dont have the equipment to deal with diseases, husked people, organ or limb loss, or cell damage, most of which is fairly common, even more so with sec. There are also some common medical equipment like stasis beds that aren't there too.

Removed Brig Physician's ability to be antag and gave them a mindshield
@ghost
Copy link

ghost commented Jul 15, 2021

Not sure if APCs and windows work very well together. Might want to move the APC on delta if you haven't already?

@Marmio64
Copy link
Contributor

Debatable on how much the sunglasses and flash are really needed, they increase the validhunt capability of them by quite a bit, they can always just work with security to heal unruly prisoners.

@Sniblet
Copy link
Contributor

Sniblet commented Jul 15, 2021

Debatable on how much the sunglasses and flash are really needed, they increase the validhunt capability of them by quite a bit

If it's not roundstart gear they can still easily get it themselves given they're in the brig, see also: detective, lawyer. A quick run to medbay and two requisitions from the warden and there you go, you've got both
The problem would be that having those things default might send a stronger message that they're meant to be used than just having them in arm's reach

Also:

  • I think Brig Physician would be the only antag-open job with perma access, will that be a problem?
  • Should it have a crew monitor? Maybe a portable one in the pocket given room space constraints?
  • Does the infirmary have anesthetics?
  • What's in the locker?
  • Is it going to be common for the Physician to build all the machines they're missing in the infirmary? Should they be given more space for this?

@nmajask
Copy link
Contributor Author

nmajask commented Jul 15, 2021

Not sure if APCs and windows work very well together. Might want to move the APC on delta if you haven't already?

Think its just a visual issue, it is supposed to be on the wall above it and that's what it looks like in dm

Debatable on how much the sunglasses and flash are really needed, they increase the validhunt capability of them by quite a bit, they can always just work with security to heal unruly prisoners.

They should have some way to protect themselves and shouldnt need to relly on sec to heal unruly prisoners. As many non-sec jobs (All heads and robo) and all sec job have access to flashes, they seem like the best tool for it. They also should have flash protection as they commonly will be around wall flashes and whatever those ones that are found in the armory. Also, if they are valid hunting as the brig physician, that will most likely be against the rules.

  • I think Brig Physician would be the only antag-open job with perma access, will that be a problem?
  • Should it have a crew monitor? Maybe a portable one in the pocket given room space constraints?
  • Does the infirmary have anesthetics?
  • What's in the locker?
  • Is it going to be common for the Physician to build all the machines they're missing in the infirmary? Should they be given more space for this?
  1. They are no longer eligible for being antag, as Tipy requested. They had the same issue.
  2. They have one, its in their locker
  3. Not on most maps, you will have to get some from medbay or use morphine. On Meta, there is one in a small room connected to the infirmary
  4. I probably should have included that in the PR, Ill update it in a sec
  5. That is probably more of a rules question, which the staff will have to decide on, but most likely they will get an engi to build it if they need it. They shouldn't need more space as they shouldn't need to add that much stuff, the only thing I could see them needing to add is a stasis bed. Even if they needed more space, I couldn't give it to them as it would require redesigning the entire brig on most maps

@Anvilman6
Copy link
Contributor

Anvilman6 commented Jul 15, 2021

Regarding the debate on sunglasses / the flash, in my view it might be better for them to have one or the other.

Security Officers, to my knowledge, don't start with both, and they're arguably in more varied and potentially dangerous situations than a Brig-based MD would be. Having one or the other cuts the potential validhunting, and makes them not flashproof and able to flash. Something to explore might be letting them keep their sunglasses, and putting a wall mounted flash with an ID-locked button somewhere in the room, so they can control unruly individuals in their own domain and nothing more.

And on the lack of anesthetic, perhaps a tank and mask could be put in the brig physician locker to unify all map configuration in having a set?

@adamsong
Copy link
Contributor

  • Brig Physician is under security in crew monitor and crew manifest
  • Brig Physician radio default channel is sec
  • Gloves don't have pick up nanites
  • No defib
  • No surgery access

@nmajask
Copy link
Contributor Author

nmajask commented Aug 20, 2021

  • Brig Physician is under security in crew monitor and crew manifest
  • Brig Physician radio default channel is sec
  • Gloves don't have pick up nanites
  • No defib
  • No surgery access
  • This is left over from when brig phys was part of sec
  • I dont know if I can change that without messing with radio code and (in my opinion) its fine
  • I gave them latex as thats what mining medics get and I didnt want to just hand out nitrite, but I can change this if you want
  • I did this so they have to bring people to medbay to get revived in the beginning of the round, but I can give them one if you want
  • Did this because mining medic doesn't have surgery access and also to not make them medical doctor+

- Fixed Brig Physician incorrectly be labeled as sec in many parts of the code
- Fixed mining medic's cap being invisable
- May have fixed the alternate job titles (I forgot to uncomment it)
Adds plasmameme outfit
@N3D6
Copy link
Contributor

N3D6 commented Aug 21, 2021

They shouldn't be able to be antag. Giving roundstart antags brig access is a horrible idea, and I feel like they should also be mindshielded so they're not an easy conversion target

@adamsong
Copy link
Contributor

Giving roundstart antags brig access is a horrible idea,

Lawyer

@N3D6
Copy link
Contributor

N3D6 commented Aug 21, 2021

Giving roundstart antags brig access is a horrible idea,

Lawyer

Lawyers have access to like, one door and sec usually doesn't even care for them enough to trust them at all
The brig physician is who you depend on as a secoff to get healed in the brig, making secoffs extremely easy targets as an antag

@adamsong
Copy link
Contributor

Lawyers have access to like, one door

Brig phys has access to the same number of sec doors as the lawyer, they just also have medical access which is what is needed for the brig phys room. Additionally, by removing the mindshield and making antag eligible, helps discourage brig phys from being a sec officer.

@burn1cycle
Copy link

Oh, you guys are already talking about it. I guess it's not a bug. Hrmmm

@burn1cycle
Copy link

After thinking about it I am going to have to shoot down brig physician. My issue is that it's problematic to increase the odds along with lawyers that we will have an antag with brig access, this is unhelpful and contradicting the purpose of why I supported brig physician.

@JamieD1 JamieD1 requested a review from a team August 24, 2021 22:50
@adamsong adamsong merged commit a75671b into yogstation13:master Aug 25, 2021
Yogbot-13 added a commit that referenced this pull request Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Awaiting - Action - HD Awaiting action from Jamie Feature This adds new content to the game Map - Approved This PR's mapping side has been approved by a mapping maintainer Mapping Will result in a change to a map. Sprites This PR has spriting changes Test Merge - Scheduled This PR is waiting to be test merged Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.